07-multi-hop: Add detailed documentation#85
Conversation
|
@miri64 How about I separate this out as a possible way to run it? Maybe move it to example1.md? Would that be easier? |
I mostly agree with what you propose, I just find the choice of configuration questionable for an official release testing procedure: The packet buffer is way too small for routers (if you try to send larger packets you will see that), the amount of configurable addresses way too big. The only thing that is a matter of taste is the number of IoT-LAB nodes picked. |
MrKevinWeiss
force-pushed
the
pr/task7
branch
from
97ae806 to
99363b4
Compare
|
I broke it out as a guide (a possible way to test). I also removed the packet_buf flag as it was added due to my ignorance and reduce the configurable addresses a bit. I think other people can add there own versions (like adding the blacklisting, I think that would be useful for automated tests). However, at this time I don't know how that is done. |
|
@miri64, I don't want to spend more time on this. I think the best way to make everyone happy is to just leave it as an unmerged PR (so I can refer back to it). Then next release I can rerun with all your recommendations (so with blacklisting and default values). Then re-document/adapt to that. |
aabadie
left a comment
aabadie
left a comment
There was a problem hiding this comment.
Would it make sense to have those 'testing procedure' suggestions inlined in the main document ? Like it is proposed in this PR, it's a bit hidden.
|
There still need to be ironed out some kinks regardless of that. Mainly, the unnecessary configuration of the number of interface IPv6 addresses |
|
Yup I will update and retest soon |
|
I think 10-icmpv6-error provides a good template how to integrate the testing procedures into the specification. |
|
@miri64 I updated to do it the l2filter_whitelist way. This way we can keep default values for everything. Please advise on how you would like me to proceed (should I keep this as an example and we leave the actual test more generic or make this the test?). |
cgundogan
left a comment
cgundogan
left a comment
There was a problem hiding this comment.
I like this test guide. It will definitely help an uninformed tester. I left a few nitpicking comments.
MrKevinWeiss
force-pushed
the
pr/task7
branch
from
0088b4c to
c5b54bf
Compare
This commit helps clarify individual steps to take to run the test. It is meant as a guide to and not a specification. Adds documentation on how to use the shell commands.
MrKevinWeiss
force-pushed
the
pr/task7
branch
from
c5b54bf to
88b62d2
Compare
|
Thanks @miri64 and @cgundogan! |
4 participants
This commit helps clarify individual steps to take to run the test.
It adds documentation on how to use the shell commands.