pkg/lwip: fix lwip_ethernet dependency#9884
Merged
cladmi merged 3 commits intoRIOT-OS:masterfrom Sep 4, 2018
Merged
Conversation
With out this fix the application or device drivers need to add this module. Otherwise, compilation of the lwIP adaptation layer will fail for Ethernet devices.
Now that `lwip_ethernet` is pulled in as a dependency of `lwip` + `netdev_eth`, it can be removed. This also makes this application more flexible for usage of non-`native` boards with Ethernet devices.
Now that `lwip_ethernet` is pulled in as a dependency of `lwip` + `netdev_eth`, it can be removed.
miri64
added
Area: network
miri64
changed the title
lwip_ethernet dependency
cladmi
approved these changes
Sep 4, 2018
Contributor
cladmi
left a comment
cladmi
left a comment
There was a problem hiding this comment.
It fixes compiling:
BOARD=arduino-due USEMODULE=enc28j60 make -C tests/lwip
Also tested that lwip_ethernet is included for native in tests/lwip, tests/lwip_sock_ip, tests/lwip_sock_tcp, tests/lwip_sock_udp.
BOARD=native make -C tests/lwip info-debug-variable-USEMODULE | grep -o lwip_ethernet
lwip_ethernet
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
With out this fix the application or device drivers need to add this module. Otherwise, compilation of the lwIP adaptation layer will fail for Ethernet devices.
This also makes the
tests/lwipapplication more flexible for usage of non-nativeboards with Ethernet devices as the implicit of thelwip_ethernetmodule there can now be removed.Testing procedure
Take any non-
nativeboard (e.g.arduino-due) and try to compiletests/lwipwith an Ethernet driver included (e.g.enc28j60). Without this PR the compilation will fail:Issues/PRs references
Found by @gschorcht when porting an ESP32 with on-board Ethernet (in #9426). He pointed this out to me offline.