Skip to content

crc validity variable in netdev_radio_rx_info and gnrc_netif_hdr_t and read it for at86rf2xx and cc2420#9755

Closed
gvz wants to merge 4 commits intoRIOT-OS:masterfrom
gvz:pr_netopt_integrity_check
Closed

crc validity variable in netdev_radio_rx_info and gnrc_netif_hdr_t and read it for at86rf2xx and cc2420#9755
gvz wants to merge 4 commits intoRIOT-OS:masterfrom
gvz:pr_netopt_integrity_check

Conversation

@gvz
Copy link
Copy Markdown
Contributor

@gvz gvz commented Aug 10, 2018

Contribution description

  • adds "crc_ok" and "fcs" to netdev_radio_rx_info and gnrc_netif_hdr_t
  • in all cases the crc_ok is set according to the state of the packet
  • fcs is read on at86rf2xx in all cases

Problem:

  • fcs is not readable on cc2420 if AUTOCRC is enabled

@gvz gvz force-pushed the pr_netopt_integrity_check branch from 186d694 to 4671e95 Compare August 10, 2018 07:28
@smlng smlng requested review from bergzand and miri64 August 10, 2018 12:35
@smlng smlng added Area: drivers Area: Device drivers GNRC labels Aug 10, 2018
@miri64 miri64 added the State: duplicate State: The issue/PR is a duplicate of another issue/PR label Aug 24, 2018
@miri64
Copy link
Copy Markdown
Member

miri64 commented Aug 24, 2018

There is some overlap with #8276. Since that one came first but adapts this feature for a different driver, could you maybe rebase on top of that PR?

@miri64
Copy link
Copy Markdown
Member

miri64 commented Sep 11, 2018

Ping @gvz?

@gvz
Copy link
Copy Markdown
Contributor Author

gvz commented Sep 14, 2018

sorry time is limited...
I tried to rebase the PRs together, seems to be more work as I hoped.

@miri64 miri64 self-assigned this Sep 25, 2018
@miri64 miri64 added Area: network Area: Networking and removed GNRC labels Sep 30, 2018
@stale
Copy link
Copy Markdown

stale bot commented Aug 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Aug 10, 2019
@stale stale bot closed this Sep 10, 2019
@jia200x
Copy link
Copy Markdown
Member

jia200x commented Apr 8, 2020

@fjmolinas also this one for #13824 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: drivers Area: Device drivers Area: network Area: Networking State: duplicate State: The issue/PR is a duplicate of another issue/PR State: stale State: The issue / PR has no activity for >185 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants