newlib.mk: llvm, fix newlib-nano header not used [backport 2018.07]#9685
Merged
cladmi merged 1 commit intoRIOT-OS:2018.07-branchfrom Aug 2, 2018
Merged
Conversation
In the previous state, with llvm and arm for example, newlib-nano include dir NEWLIB_NANO_INCLUDE_DIR is placed after NEWLIB_INCLUDES and so the default 'newlib.h' is used instead of the nano version. (cherry picked from commit f8e1419)
cladmi
added
Process: release backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9513
Contribution description
This fixes building with llvm where newlib-nano header is not used.
Basically, the default newlib directory was put before newlib-nano include directory.
Test command
The first commit can be tested to show it is broken and that the second fixes it
Output
Without patch:
You can notive that 'newlib-nano' is not in front
With the fix, newlib-nano directory is in front.
Replaced by #9599
Issues/PRs references
Split from #9512