pkg/libfixmath: replace __FILE__ by RIOT_FILE_NOPATH [backport 2018.07]#9657
Merged
miri64 merged 1 commit intoRIOT-OS:2018.07-branchfrom Jul 31, 2018
Merged
Conversation
cladmi
added
Process: release backport
Contributor
Author
|
It is correctly building with |
Contributor
Author
|
And tests still work for |
miri64
added
CI: ready for build
Member
|
Needs rebase |
ZetaR60
previously approved these changes
Jul 31, 2018
The binary file size changes when the RIOT directory is moved. This caused the `libfixmath_unittests` to fail on my computer. I used RIOT_FILE_NOPATH instead of RIOT_FILE_RELATIVE as 'TEST' is used a lot and it would allow more boards to be tested, full path is not that important. (cherry picked from commit 7913dd9)
cladmi
force-pushed
the
2018.07/pr/libfixmath/debug
branch
from
ccede64 to
aba573c
Compare
miri64
approved these changes
Jul 31, 2018
Member
miri64
left a comment
miri64
left a comment
There was a problem hiding this comment.
Re-ACK after automatic dismiss due to rebase to protected release branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9643
Contribution description
Update the TEST macro to use our
RIOT_FILE_RELATIVERIOT_FILE_NOPATH macro.The binary file size changes when the RIOT directory is moved.
This caused the
libfixmath_unitteststo fail on my computer.This saves
18726632 bytes of rom forsamr21-xproon my computer.Issues/PRs references
Same reasons as why the macro was introduced #2969
Found during release testing