Skip to content

toolchain/gnu: also define NM#9624

Merged
jcarrano merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/make/nm
Jul 24, 2018
Merged

toolchain/gnu: also define NM#9624
jcarrano merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/make/nm

Conversation

@cladmi
Copy link
Copy Markdown
Contributor

@cladmi cladmi commented Jul 23, 2018

Contribution description

Define NM when TOOLCHAIN=gnu

llvm is defining NM already and openthread is using the symbol.

Testing

With this PR you correctly have an output for info-debug-variable-NM with TOOLCHAIN=gnu

make --no-print-directory -C examples/hello-world/ BOARD=samr21-xpro info-debug-variable-NM TOOLCHAIN=gnu
arm-none-eabi-nm

make --no-print-directory -C examples/hello-world/ BOARD=samr21-xpro info-debug-variable-NM TOOLCHAIN=llvm
llvm-nm

make --no-print-directory -C examples/hello-world/ BOARD=native info-debug-variable-NM TOOLCHAIN=gnu 
nm

make --no-print-directory -C examples/hello-world/ BOARD=native info-debug-variable-NM TOOLCHAIN=llvm
llvm-nm

Issues/PRs references

Used in #9599

@cladmi
toolchain/gnu: also define NM
cde5a91 
llvm is defining NM already and `openthread` is using the symbol.
@cladmi cladmi added Area: build system Area: Build system Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 23, 2018
@cladmi cladmi requested a review from jcarrano July 23, 2018 15:40
jcarrano
jcarrano approved these changes Jul 24, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@jcarrano jcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward. Works for me.

@jcarrano jcarrano merged commit d3b5a79 into RIOT-OS:master Jul 24, 2018
@cladmi cladmi deleted the pr/make/nm branch July 24, 2018 11:52
@cladmi cladmi mentioned this pull request Jul 25, 2018
Merged
@cladmi
Copy link
Copy Markdown
Contributor Author

cladmi commented Jul 25, 2018

Backport provided in #9632

@cladmi cladmi added the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Aug 11, 2018
@cladmi cladmi added this to the Release 2018.07 milestone Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jcarrano jcarrano jcarrano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch

Projects

None yet

Milestone

Release 2018.07

Development

Successfully merging this pull request may close these issues.

2 participants

@cladmi @jcarrano