Skip to content

cflags.inc.mk: fix cflags test for llvm#9612

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/make/cflags/llvm
Jul 19, 2018
Merged

cflags.inc.mk: fix cflags test for llvm#9612
miri64 merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/make/cflags/llvm

Conversation

@cladmi
Copy link
Copy Markdown
Contributor

@cladmi cladmi commented Jul 19, 2018 •
edited
Loading

Contribution description

gcc does an error but not clang, so add -Werror

Previous from #9355 llvm was handling all flags that are now with the cflags_test_and_add check.

Testing

This now fails in master but works with this PR

make BOARD=samr21-xpro TOOLCHAIN=clang -C examples/hello-world/ clean all
error: unknown warning option '-Wformat-overflow'; did you mean '-Wshift-overflow'? [-Werror,-Wunknown-warning-option]
error: unknown warning option '-Wformat-truncation' [-Werror,-Wunknown-warning-option]

Further work

I think it could even be applied to the other checks that currently use grep warning:.
But would be for another PR.

Issues/PRs references

Found for llvm support in murdock: #9398

@cladmi
cflags.inc.mk: fix cflags test for llvm
a99dd33 
gcc does an error but not clang, so add -Werror.
@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: build system Area: Build system Area: toolchain Area: toolchains; everything related to compilation, libc, linking, … CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch labels Jul 19, 2018
@miri64 miri64 added this to the Release 2018.07 milestone Jul 19, 2018
miri64
miri64 reviewed Jul 19, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Ubuntu 16.04.4 and Ubuntu 17.10. Docker wasn't working for me for some reason:

docker: Error response from daemon: invalid header field value "oci runtime error: container_linux.go:247: starting container process caused \"process_linux.go:334: running prestart hook 0 caused \\\"fork/exec /usr/bin/dockerd (deleted): no such file or directory\\\"\"\n".

But since this is working in #9398 I guess I don't have to.

@cladmi cladmi mentioned this pull request Jul 19, 2018
Merged
@miri64 miri64 merged commit 2412c00 into RIOT-OS:master Jul 19, 2018
@cladmi cladmi mentioned this pull request Jul 19, 2018
Closed
@cladmi
Copy link
Copy Markdown
Contributor Author

cladmi commented Jul 19, 2018

In fact the CFLAGS changes are not included in the release so this is maybe not necessary to backport.

@miri64 miri64 removed the Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch label Jul 19, 2018
@cladmi cladmi mentioned this pull request Jul 19, 2018
Closed
@miri64
Copy link
Copy Markdown
Member

miri64 commented Jul 19, 2018

I remove the label then ;-)

@cladmi cladmi deleted the pr/make/cflags/llvm branch July 19, 2018 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miri64 miri64 miri64 approved these changes

Assignees

No one assigned

Labels

Area: build system Area: Build system Area: toolchain Area: toolchains; everything related to compilation, libc, linking, … CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2018.07

Development

Successfully merging this pull request may close these issues.

2 participants

@cladmi @miri64