Skip to content

lwip: fix parentheses equality issue#9605

Closed
miri64 wants to merge 1 commit intoRIOT-OS:masterfrom
miri64:pkg/fix/lwip-parentheses-macro
Closed

lwip: fix parentheses equality issue#9605
miri64 wants to merge 1 commit intoRIOT-OS:masterfrom
miri64:pkg/fix/lwip-parentheses-macro

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Jul 19, 2018

Contribution description

Another issue revealed by llvm. Since this is caused by the resolution
of a macro in lwIP this can't be solved as a patch, so we just ignore
the warning.

Issues/PRs references

Fixes an issue revealed by #9398.

@miri64
lwip: fix parentheses equality issue
68888b9 
Another issue revealed by `llvm`. Since this is caused by the resolution
of a macro in lwIP this can't be solved as a patch, so we just ignore
the warning.
@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking Area: pkg Area: External package ports labels Jul 19, 2018
@miri64 miri64 added this to the Release 2018.07 milestone Jul 19, 2018
@miri64 miri64 requested a review from cladmi July 19, 2018 12:19
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 19, 2018
miri64 added a commit to miri64/RIOT that referenced this pull request Jul 19, 2018
@miri64
Merge 'pkg/fix/lwip-parentheses-macro' (RIOT-OS#9605)
478f9bb
miri64 added a commit to miri64/RIOT that referenced this pull request Jul 19, 2018
@miri64
Merge 'pkg/fix/lwip-parentheses-macro' (RIOT-OS#9605)
1c0fc6e
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jul 19, 2018

@cladmi wanna give it a try?

@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented Jul 19, 2018

I will.

But currently I need to listen to juan presenting this for the moment. And try to backport the #9612 pr.

miri64 added a commit to miri64/RIOT that referenced this pull request Jul 19, 2018
@miri64
Merge 'pkg/fix/lwip-parentheses-macro' (RIOT-OS#9605)
803aec1
@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented Jul 25, 2018

I do not manage to make this fail in master even in docker…
I tried compiling all tests/lwip* with samr21-xpro.

make -C tests/lwip BOARD=samr21-xpro TOOLCHAIN=llvm  clean all BUILD_IN_DOCKER=1

Compiles without issue.

Do you remember which test was broken ?

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jul 25, 2018

Murdock complained in every lwip application about this.

@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented Jul 25, 2018

Then I miss something on how it is build. Is not murdock using the riot/riotbuild image ?

I also tested with native using ffd8b52 and it does not fail…

@cladmi cladmi mentioned this pull request Jul 27, 2018
Closed
6 tasks
miri64 added a commit to miri64/RIOT that referenced this pull request Jul 31, 2018
@miri64
Merge 'pkg/fix/lwip-parentheses-macro' (RIOT-OS#9605)
3b36a8c
@miri64 miri64 mentioned this pull request Jul 31, 2018
Merged
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jul 31, 2018

@cladmi I reverted 68888b9 in #9398 to show you.

@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented Jul 31, 2018

@miri64 I see them thank you. I still would like to know why it is only failing in murdock and not in Ubuntu16.04 or the Docker image. @kaspar030 @smlng do you have any ideas ?

I will merge if it is the last thing blocking #9398 even if unsolved.

@cladmi cladmi mentioned this pull request Aug 2, 2018
Merged
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Aug 3, 2018

Not an issue after all with the correct compile config, so close.

@miri64 miri64 closed this Aug 3, 2018
@miri64 miri64 added the State: invalid State: The issue / PR is not valid label Aug 3, 2018
@miri64 miri64 deleted the pkg/fix/lwip-parentheses-macro branch August 3, 2018 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cladmi cladmi Awaiting requested review from cladmi

Assignees

No one assigned

Labels

Area: network Area: Networking Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR State: invalid State: The issue / PR is not valid Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2018.10

Development

Successfully merging this pull request may close these issues.

2 participants

@miri64 @cladmi