at86rf2xx: Move flags from netdev to radio#9581
Merged
bergzand merged 1 commit intoRIOT-OS:masterfrom Aug 17, 2018
Merged
Conversation
The flags from the ieee802154 struct are only used in the radio code. there is no advantage of having them in the netdev_ieee802154_t struct if the flags are defined differently per radio driver.
bergzand
added
Type: enhancement
Member
Author
|
This changes the default flags enabled for the radio ( |
Member
|
@bergzand I tested and according to |
Member
|
because AUTOACK is enable on |
smlng
approved these changes
Aug 1, 2018
Member
smlng
left a comment
smlng
left a comment
There was a problem hiding this comment.
makes sense to move driver/device specific flags, ACK
Member
|
Green lights @smlng! |
Member
|
@bergzand question: what was |
Member
Author
|
@smlng Looking at changes from a long time ago, this was from when part of what is now handled in netif. I would say similar to the current |
jnohlgard
pushed a commit
to eistec/RIOT
that referenced
this pull request
Nov 13, 2018
jnohlgard
pushed a commit
to jnohlgard/RIOT
that referenced
this pull request
Nov 13, 2018
jnohlgard
pushed a commit
to jnohlgard/RIOT
that referenced
this pull request
Nov 23, 2018
jnohlgard
pushed a commit
to jnohlgard/RIOT
that referenced
this pull request
Dec 1, 2018
jnohlgard
pushed a commit
to jnohlgard/RIOT
that referenced
this pull request
Dec 1, 2018
jnohlgard
pushed a commit
to jnohlgard/RIOT
that referenced
this pull request
Dec 10, 2018
jnohlgard
pushed a commit
to jnohlgard/RIOT
that referenced
this pull request
Dec 10, 2018
jnohlgard
pushed a commit
to jnohlgard/RIOT
that referenced
this pull request
Dec 11, 2018
jnohlgard
pushed a commit
to eistec/RIOT
that referenced
this pull request
Dec 11, 2018
jnohlgard
pushed a commit
to jnohlgard/RIOT
that referenced
this pull request
Dec 14, 2018
benemorius
pushed a commit
to benemorius/RIOT
that referenced
this pull request
Jun 22, 2019
benemorius
pushed a commit
to benemorius/RIOT
that referenced
this pull request
Jun 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The flags from the ieee802154 struct are only used in the radio code, there is no advantage of having make sense to have them in the netdev struct if their meaning is different per radio driver.
Also fixes a bug where (un)setting the
AUTOACKflag would (un)set theACK_REQflag.Issues/PRs references
Minor cleanup preparing for #7736
Similar PRs are required for the other radio drivers using flags.