Merged
Conversation
`sock_util` includes the `arpa/inet.h` header so it has `posix` as a dependency to include the `sys/posix/include` include path.
miri64
added
Type: bug
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Jul 4, 2018
Adapt for opinion change in RIOT-OS#9498 ;-).
smlng
added
the
CI: ready for build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
sock_utilincludes thearpa/inet.hheader so it hasposixas a dependency to include thesys/posix/includeinclude path.I kept the explicit inclusion in
tests/gnrc_sock_dns, since its main file also includesarpa/inet.h.Issues/PRs references
Originally created in #8646, but since the review is stalled there and
sock_utilis needed for #9464 to remove some code duplication / misplacement of new functionality, I cherry-picked it out of there