gnrc_sixlowpan_frag: Expose functions to finish datagram#9483
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Jul 25, 2018
Merged
gnrc_sixlowpan_frag: Expose functions to finish datagram#9483miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64 merged 1 commit intoRIOT-OS:masterfrom
Conversation
miri64
added
Type: enhancement
miri64
force-pushed
the
gnrc_sixlowpan_frag/enh/finish-frag
branch
from
2eb350f to
8239a02
Compare
cgundogan
requested changes
Jul 24, 2018
Member
cgundogan
left a comment
cgundogan
left a comment
There was a problem hiding this comment.
Tested on the the testbed. Fragmentation still works. I have a minor change request for a function name (see below), though.
| * Used to construct the @ref gnrc_netif_hdr_t of the completed | ||
| * datagram. Must not be NULL. | ||
| */ | ||
| void gnrc_sixlowpan_frag_rbuf_check(gnrc_sixlowpan_rbuf_t *rbuf, |
Member
There was a problem hiding this comment.
_check as a function name is quite misleading when there is no virtual return value. How about renaming it to _dispatch or dispatch_on_complete?
Member
Author
There was a problem hiding this comment.
How about _dispatch_when_complete? This way it doesn't sound to be like it's supposed to be an event handler.
This will be used in the IPHC refactoring to control the reassembly buffer as a context. I also adapted the name of `gnrc_sixlowpan_frag_gc_rbuf()` to be in line with the rest of the newer functions.
miri64
force-pushed
the
gnrc_sixlowpan_frag/enh/finish-frag
branch
from
c39f8db to
64fed62
Compare
Member
Author
|
Squashed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This will be used in the IPHC refactoring to control the reassembly buffer as a context.
I also adapted the name of
gnrc_sixlowpan_frag_gc_rbuf()to be in line with the rest of the newer functions.Issues/PRs references
None