drivers/lc709203f: adapt to new i2c API#9481
Merged
dylad merged 1 commit intoRIOT-OS:new_i2c_iffrom Jul 9, 2018
Merged
Conversation
MichelRottleuthner
added
Area: drivers
47 tasks
dylad
reviewed
Jul 3, 2018
Member
dylad
left a comment
dylad
left a comment
There was a problem hiding this comment.
Overall changes are ok.
Would be great if someone can test it !
Contributor
|
@dylad So it builds for me and the code looks good. I don't think we can find the hardware so I will add it to the list and you can merge if you like. |
Member
|
Can you rebase please ? so Travis will be happy. |
MichelRottleuthner
force-pushed
the
pr_lc709203f_new_i2c
branch
from
93e2c5f to
79da68d
Compare
Contributor
Author
|
rebased |
basilfx
pushed a commit
to basilfx/RIOT
that referenced
this pull request
Jul 10, 2018
…new_i2c drivers/lc709203f: adapt to new i2c API
dylad
added a commit
to dylad/RIOT
that referenced
this pull request
Jul 10, 2018
…new_i2c drivers/lc709203f: adapt to new i2c API
Contributor
|
Eventhough its already merged: Just tested it on the jiminy-mega256rfr2 and can confirm the changes as working |
Contributor
Author
|
thanks for testing @shr70 :) |
9 tasks
Member
|
@shr70 thanks a lot for testing. This is highly appreciate ! |
dylad
added a commit
that referenced
this pull request
Jul 11, 2018
drivers/lc709203f: adapt to new i2c API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This adapts the lc709203f driver to the new i2c api. I don't have hardware to test. (maybe @shr70 want's to help out here?)
(note for future PR: the driver has a lot of code that can be deduplicated)
Issues/PRs references
#6577