tools: add mosquitto.rsmb MQTT-SN broker#9459
Conversation
haukepetersen
added
Type: new feature
miri64
left a comment
miri64
left a comment
There was a problem hiding this comment.
In general I'm having some stomach ache pulling in "random" daemons, but I understand your motivation, so ACK.
Some remarks: I can't build from RIOTBASE, only from an application directory. Maybe something to consider?
makefiles/tools/targets.inc.mk
Outdated
| # (as `all`), so `all` will always be the first target defined and thereby the | ||
| # default target when `make` is called without any further argument. | ||
|
|
||
| .PHONY: rsmb |
There was a problem hiding this comment.
I have the feeling that this target name is too generic and should maybe be mqtt_rsmb or mosquitto_rsmb instead.
There was a problem hiding this comment.
mosquitto_rsmb it is :-)
true, I have never even considered this. Will think about a fix. |
|
Hmm, maybe not. Making the tool target available from the RIOT root would force us to include the target in the global |
|
renamed target and added logfiles to .gitignore |
miri64
left a comment
miri64
left a comment
There was a problem hiding this comment.
Some minor stuff popped up on my revisit. Will Re-ACK, when addressed.
dist/tools/mosquitto_rsmb/Makefile
Outdated
|
|
||
| all: git-download | ||
| # Start rsmb build in a clean environment, so variables set by RIOT's build process | ||
| # for cross compiling a specific target platform are reset and edbg can |
There was a problem hiding this comment.
I guess you mean mosquitto_rsmb here instead of edbg?
dist/tools/mosquitto_rsmb/Makefile
Outdated
| all: git-download | ||
| # Start rsmb build in a clean environment, so variables set by RIOT's build process | ||
| # for cross compiling a specific target platform are reset and edbg can | ||
| # be built cleanly for the native platform. |
There was a problem hiding this comment.
Maybe "host platform" instead of "native platform" to distinguish it from the native port?
dist/tools/mosquitto_rsmb/Makefile
Outdated
| @@ -0,0 +1,35 @@ | |||
| PKG_NAME = rsmb | |||
There was a problem hiding this comment.
Can you change the name here as well please?
Right! |
haukepetersen
force-pushed
the
add_tool_rsmb
branch
from
4a25417 to
45a4b96
Compare
|
addressed comments and squashed:
|
haukepetersen
force-pushed
the
add_tool_rsmb
branch
from
45a4b96 to
d5c8ac2
Compare
haukepetersen
force-pushed
the
add_tool_rsmb
branch
from
d5c8ac2 to
3ccb27d
Compare
miri64
added
the
CI: ready for build
|
tack! |
6 participants
Contribution description
This PR adds the build and a run configuration for the Mosquitto.rsmb (really small message broker), a small MQTT(-SN) gateway and server. Having this in RIOT is very helpful when testing anything MQTT-SN related (as e.g.
examples/emcuteor my upcoming, asynchronous MQTT-SN client implementation). So instead of going through the trouble following the 'setup-guide' in examples/emcute_mqttsn/README.md, one can now simply start a pre-configured MQTT-SN gateway instance by simply issuingThis will further be useful when designing an automated test setup...
Issues/PRs references
none yet