Skip to content

drivers/hdc1000: change renew_interval to a parameter#9386

Merged
MichelRottleuthner merged 1 commit intoRIOT-OS:masterfrom
Hyungsin:forupstream_hdc1000
Aug 7, 2018
Merged

drivers/hdc1000: change renew_interval to a parameter#9386
MichelRottleuthner merged 1 commit intoRIOT-OS:masterfrom
Hyungsin:forupstream_hdc1000

Conversation

@Hyungsin
Copy link
Copy Markdown

@Hyungsin Hyungsin commented Jun 20, 2018 •
edited
Loading

Contributions

This PR changes HDC1000_RENEW_INTERVAL to HDC1000_PARAM_RENEW_INTERVAL, as a parameter. This is for consistency with FXOS8700 driver in #8978.

Issues/PRs references

#8978

@Hyungsin Hyungsin mentioned this pull request Jun 20, 2018
Merged
@MichelRottleuthner MichelRottleuthner added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 21, 2018
@MichelRottleuthner MichelRottleuthner self-assigned this Jun 21, 2018
MichelRottleuthner
MichelRottleuthner approved these changes Jun 21, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@MichelRottleuthner MichelRottleuthner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK (untested)

@dylad dylad added the State: waiting for other PR State: The PR requires another PR to be merged first label Jun 21, 2018
@dylad
Copy link
Copy Markdown
Member

dylad commented Jun 21, 2018

This PR hits the current I2C embargo. Sorry but we will have to wait the end of the I2C refactoring to merge it :(

@dylad dylad removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 21, 2018
@dylad
Copy link
Copy Markdown
Member

dylad commented Jun 21, 2018

The big green button is still here but please do not click on it :)

MichelRottleuthner
MichelRottleuthner requested changes Jun 21, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@MichelRottleuthner MichelRottleuthner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking just to be sure nobody presses this nice green button before i2c refactoring is done and this PR is adapted ;)

@Hyungsin
Copy link
Copy Markdown
Author

Hyungsin commented Jun 28, 2018

@dylad, @MichelRottleuthner.
I don't see any PR regarding I2C refactoring for the hdc1000 yet and this PR does not change anything about I2C. So IMHO, adapting hdc1000 driver's I2C setting can be done after merging this PR. How do you think about that?

@dylad
Copy link
Copy Markdown
Member

dylad commented Jun 28, 2018

Nobody work on it yet but i hope it will be done soon. If we merge this PR, we will face merge issue on the new_i2c_if branch when we will try to merge it to master. We don't want the burden of backporting to solve merge issue, so we should wait before merging it.
Sorry :/

@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Jun 28, 2018

@Hyungsin, since you have the hardware and know a bit the driver, maybe you could provide a PR to adapt hdc1000 to the new I2C interface ?

@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Jun 28, 2018

You'll have to open a PR against new_i2c_if branch instead of master.

@Hyungsin
Copy link
Copy Markdown
Author

Hyungsin commented Jun 28, 2018

@aabadie, @dylad, I opend #9455 to reflect i2c refactoring. Thanks :)

@Hyungsin Hyungsin force-pushed the forupstream_hdc1000 branch from ee7a1e6 to 9c1bd4d Compare August 2, 2018 18:28
@Hyungsin
Copy link
Copy Markdown
Author

Hyungsin commented Aug 2, 2018

@MichelRottleuthner, resolved conflict after the i2c refactoring is done.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Aug 2, 2018

@MichelRottleuthner, resolved conflict after the i2c refactoring is done.

It is.

@dylad dylad removed the State: waiting for other PR State: The PR requires another PR to be merged first label Aug 2, 2018
@MichelRottleuthner MichelRottleuthner added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 6, 2018
@MichelRottleuthner
Copy link
Copy Markdown
Contributor

MichelRottleuthner commented Aug 6, 2018

@Hyungsin why does your commit state "Your Name" as author? Played with your git config? ;)

@Hyungsin Hyungsin force-pushed the forupstream_hdc1000 branch from 9c1bd4d to fa2ea16 Compare August 6, 2018 18:09
@Hyungsin
Copy link
Copy Markdown
Author

Hyungsin commented Aug 6, 2018

@MichelRottleuthner, My bad.... :( Good observation and I changed it! 👍

@Hyungsin Hyungsin force-pushed the forupstream_hdc1000 branch from fa2ea16 to c2cfc97 Compare August 6, 2018 19:32
@Hyungsin Hyungsin force-pushed the forupstream_hdc1000 branch from c2cfc97 to 88895bb Compare August 6, 2018 19:34
@MichelRottleuthner MichelRottleuthner merged commit 6bc069e into RIOT-OS:master Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichelRottleuthner MichelRottleuthner MichelRottleuthner approved these changes

Assignees

@MichelRottleuthner MichelRottleuthner

Labels

Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Hyungsin @dylad @aabadie @miri64 @MichelRottleuthner