Skip to content

core: add more stacksize defines#9356

Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
kaspar030:add_more_stacksize_defines
Jun 15, 2018
Merged

core: add more stacksize defines#9356
kaspar030 merged 1 commit intoRIOT-OS:masterfrom
kaspar030:add_more_stacksize_defines

Conversation

@kaspar030
Copy link
Copy Markdown
Contributor

@kaspar030 kaspar030 commented Jun 14, 2018

Contribution description

This PR adds more stacksize defines: tiny, small, medium, large being 1/4, 1/2, 1 and 2 times of the default size.

They can be combined, see @miri64's suggestion here: #1976 (comment).

Issues/PRs references

Fixes #1976.

See #6273, #6669.

@kaspar030 kaspar030 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: core Area: RIOT kernel. Handle PRs marked with this with care! Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 14, 2018
jnohlgard
jnohlgard reviewed Jun 14, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@jnohlgard jnohlgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but I would like to hear the opinion of @miri64, since she opened the original issue

miri64
miri64 approved these changes Jun 15, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@miri64
Copy link
Copy Markdown
Member

miri64 commented Jun 15, 2018

(As core PR: needs second ACK?)

bergzand
bergzand approved these changes Jun 15, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@bergzand bergzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK!

@kaspar030
Copy link
Copy Markdown
Contributor Author

kaspar030 commented Jun 15, 2018

And go. Now we can start measuring and fixing tests for nucleo-f031k6. ;)

@kaspar030 kaspar030 merged commit 17b661b into RIOT-OS:master Jun 15, 2018
@kaspar030 kaspar030 deleted the add_more_stacksize_defines branch June 15, 2018 09:04
@miri64 miri64 mentioned this pull request Jun 18, 2018
Merged
@kYc0o kYc0o mentioned this pull request Jun 26, 2018
Closed
@cladmi cladmi added this to the Release 2018.07 milestone Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnohlgard jnohlgard jnohlgard left review comments

@miri64 miri64 miri64 approved these changes

@bergzand bergzand bergzand approved these changes

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

Assignees

No one assigned

Labels

Area: core Area: RIOT kernel. Handle PRs marked with this with care! CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2018.07

Development

Successfully merging this pull request may close these issues.

5 participants

@kaspar030 @miri64 @jnohlgard @bergzand @cladmi