core/byteorder: add uint16 from/to buffer funcs#9301
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Jun 7, 2018
Merged
Conversation
haukepetersen
added
Type: enhancement
cgundogan
approved these changes
Jun 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
A typical use case when implementing network protocols or similar is to read/write integers from/to buffers while casting them between host and le/be byte orders. The problem here is, that the values in the target buffers are not aligned, so a simple casting of multiple byte values does lead to hard-faults on some platforms (e.g. cortex-m0).
This PR adds two byteorder functions that can read/write
uint16_tvars from/to buffers with any alignment. So far I added only two functions for writing/reading little endian values. I think it makes most sense to add be and/or other bit width functions on demand later.I found that I copied these function to multiple modules, so having them in one central place make probably the most sense, right?!
Issues/PRs references
none