Also, would it be a good idea to enable -Wswitch-default to warn about switch statements without default case?

Just wondering : Can't we just replace case 2 by default ?

@dylad: catching the default case is better.

@josephnoir any advise here?

@dylad I think that having

default:
case 2:
  code();

Makes it clear that "2" is an expected value, and that for other values we do the same as if the value was 2. Of course, if "case 2:" is omitted, the program is perfectly equivalent, but in my opinion less clear.

Sure ! I was just wondering.
If we take this option, please add a comment /* Falls through */ so we won't raise a new compiler warning later.
edit : if needed

@dylad Done.

Murdock is green.
@kaspar030 @dylad @basilfx is it ok for you to merge this PR?

Should I rebase?

@jcarrano yup. And then we merge

Also, would it be a good idea to enable -Wswitch-default to warn about switch statements without default case?

What is the correct place to discuss such a proposal?

@jcarrano either a GH issue or devel list

Murdock green and go

@jcarrano Create a new PR for it. It sounds like a good idea to enable that warning for all platforms which support it.

Murdock green -> GO