Skip to content

drivers/isrpipe: changed isrpipe_t content order#9240

Merged
cgundogan merged 1 commit intoRIOT-OS:masterfrom
maxvankessel:pr/isrpipe
Jul 2, 2018
Merged

drivers/isrpipe: changed isrpipe_t content order#9240
cgundogan merged 1 commit intoRIOT-OS:masterfrom
maxvankessel:pr/isrpipe

Conversation

@maxvankessel
Copy link
Copy Markdown
Contributor

@maxvankessel maxvankessel commented May 30, 2018

Wouldn't it be more handy to change order of content in isrpipe_t?
So tsrb functions like tsrb_full and tsrb_empty can be accessed with an isrpipe_t.

isrpipe_t extends tsrb_t right?

@maxvankessel maxvankessel mentioned this pull request Jun 22, 2018
Merged
@vincent-d vincent-d requested a review from kaspar030 June 22, 2018 21:08
@vincent-d vincent-d added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Jun 22, 2018
@cgundogan
Copy link
Copy Markdown
Member

cgundogan commented Jul 2, 2018

@kaspar030 I am not quite familiar with the isrpipe module. To me the change looks quite unintrusive. Would you mind having a second look at it?

@cgundogan cgundogan added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 2, 2018
kaspar030
kaspar030 approved these changes Jul 2, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kaspar030
Copy link
Copy Markdown
Contributor

kaspar030 commented Jul 2, 2018

Thanks @maxvankessel!

@cgundogan cgundogan merged commit e5c6d0e into RIOT-OS:master Jul 2, 2018
@cladmi cladmi added this to the Release 2018.07 milestone Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

Assignees

No one assigned

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2018.07

Development

Successfully merging this pull request may close these issues.

5 participants

@maxvankessel @cgundogan @kaspar030 @cladmi @vincent-d