newlib-nano: Add workaround for systems without nano includes.#9215
Closed
jcarrano wants to merge 1 commit intoRIOT-OS:masterfrom
Closed
newlib-nano: Add workaround for systems without nano includes.#9215jcarrano wants to merge 1 commit intoRIOT-OS:masterfrom
jcarrano wants to merge 1 commit intoRIOT-OS:masterfrom
Conversation
Contributor
Author
|
@kYc0o Can you verify this is a fix for OSX? |
Contributor
Author
|
This is hacky, #9216 is a better solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Some systems (OSX, ArchLinux) do not ship separate headers for newlib nano. All the standard system headers for nano should be the same with the exception of
newlib.h.The result for these systems is that the
NEWLIB_NANO_INCLUDE_DIRis empty and the include line is wrongly formed.This is a workaroround that reverts to the old behavior of using the non-nano include path if
NEWLIB_NANO_INCLUDE_DIRis empty.Issues/PRs references
Fixes #9214, which was introduced by #9080 .