tests/xtimer_periodic_wakeup: all states#9108
Closed
Josar wants to merge 1 commit intoRIOT-OS:masterfrom
Closed
Conversation
Contributor
|
I successfully ran the tests on the following boards:
I did not review the code changes though. |
Contributor
Author
|
Ping |
Member
|
@cladmi I think this is a perfect Hack'n'ACK candidate, don't you think so? |
Member
|
@cladmi now that you already ran some tests would you mind to provide a review? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds additional test for all states in the xtimer_periodic_wakeup() function.
Untill now there was no dependency of the parameter XTIMER_PERIODIC_SPIN and XTIMER_PERIODIC_RELATIVE which ensures to test all possible configuration.
in some cases only spinning and relativ timestamps where tested.
The test is now changed to test spinning, relativ timestamp and also absolut timestamping.