Skip to content

tests/xtimer_periodic_wakeup: all states#9108

Closed
Josar wants to merge 1 commit intoRIOT-OS:masterfrom
Josar:pr/xtimer_periodic_wakeup
Closed

tests/xtimer_periodic_wakeup: all states#9108
Josar wants to merge 1 commit intoRIOT-OS:masterfrom
Josar:pr/xtimer_periodic_wakeup

Conversation

@Josar
Copy link
Copy Markdown
Contributor

@Josar Josar commented May 9, 2018

This PR adds additional test for all states in the xtimer_periodic_wakeup() function.
Untill now there was no dependency of the parameter XTIMER_PERIODIC_SPIN and XTIMER_PERIODIC_RELATIVE which ensures to test all possible configuration.

in some cases only spinning and relativ timestamps where tested.

The test is now changed to test spinning, relativ timestamp and also absolut timestamping.

@cladmi
Copy link
Copy Markdown
Contributor

cladmi commented May 11, 2018

I successfully ran the tests on the following boards:

  • samr21-xpro: Min/max error: 7/40
  • iotlab-: Min/max error: 1/21
  • wsn430-v1_4: Min/max error: 14/129
  • arduino-zero: Min/max error: 7/46

I did not review the code changes though.

@tcschmidt tcschmidt requested a review from kaspar030 May 26, 2018 21:11
@Josar
Copy link
Copy Markdown
Contributor Author

Josar commented Sep 18, 2018

Ping

@PeterKietzmann PeterKietzmann added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: tests Area: tests and testing framework Area: timers Area: timer subsystems labels Sep 25, 2018
@PeterKietzmann
Copy link
Copy Markdown
Member

@cladmi I think this is a perfect Hack'n'ACK candidate, don't you think so?

@PeterKietzmann
Copy link
Copy Markdown
Member

@cladmi now that you already ran some tests would you mind to provide a review?

@stale
Copy link
Copy Markdown

stale bot commented Aug 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Aug 10, 2019
@stale stale bot closed this Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: tests Area: tests and testing framework Area: timers Area: timer subsystems State: stale State: The issue / PR has no activity for >185 days Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants