drivers: add driver for APDS9007 illuminance sensor by Hyungsin · Pull Request #8989 · RIOT-OS/RIOT

Hyungsin · 2018-04-19T23:06:19Z

This PR provides a driver implementation for APDS9007 illuminance sensor.
APDS9007 gives raw voltage value which is proportional to "lux".
This driver reads this voltage value through ADC, which needs to be converted to "lux" according to passive components. The voltage->lux conversion is out of the scope of this PR.

Note:
APDS9007's illuminance output is 3 to 70,000 lux, which cannot be captured by a 16 bit variable.
But raw voltage output is 0 to 3000 mV, which is durable.

Dependencies

#9013

aabadie

This PR looks good. I don't have have the hardware so I can't test.

You need to uncrustify apds9007.c and apds9007_saul.c (opening curly braces of a function should be on next line).

aabadie · 2018-07-03T06:46:31Z

Also this PR needs to be rebased.

Hyungsin · 2018-07-03T07:25:21Z

@aabadie, done!

aabadie

Travis is reporting issues. And it seems the apds9007.h file is missing !

drivers/apds9007/apds9007_saul.c

Hyungsin · 2018-07-03T07:59:47Z

@aabadie. Oops. resolved again :)

PeterKietzmann · 2019-03-05T10:12:35Z

@Hyungsin is this part of the Hamilton board? If so, @danpetry could you test it?

Hyungsin · 2019-03-15T18:45:21Z

@PeterKietzmann, @danpetry, yes please! I just came back to the development world and believe that #9013 is almost done.

PeterKietzmann · 2019-05-22T06:48:00Z

#9013 was merged, @danpetry disappeared. Is there anyone else with access to this sensor or a Hamilton board? @emmanuelsearch? @jcarrano? @SemjonKerner?

ghost · 2019-05-24T10:15:52Z

I did find some Hamilton boards, but none with the sensor so far. I'll keep looking.

jcarrano · 2019-05-27T15:23:18Z

Yeah, I have a Hamilton.

stale · 2019-11-28T16:22:40Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

benpicco · 2019-11-28T16:29:13Z

The board is merged now and the driver is pretty simple.
Want to give this a rebase?

Hyungsin · 2019-11-28T23:39:50Z

Want to give this a rebase?

done

benpicco

Sorry for the long dormancy, it took the stale bot to bring this back to live.

Some minor things: I'd rename the 'gpio' to shutdown so it matches the data sheet and it's function.
Since it's not needed for basic sensor operation, you should also handle the GPIO_UNDEF case.

I agree that it doesn't make much sense to convert this to lux since that would just mean multiplying it by an unknown factor and introducing inaccuracies.

benpicco · 2019-11-29T08:44:18Z

drivers/include/apds9007.h

+ * @brief   Parameters needed for device initialization
+ */
+typedef struct {
+    gpio_t    gpio;            /**< GPIO pin that sensor is connected to */


The data sheet calls this pin 'shutdown' which also makes sense given it's function.

benpicco · 2019-11-29T08:50:04Z

drivers/apds9007/apds9007.c

+    dev->p.adcline = params->adcline;
+    dev->p.adcres  = params->adcres;
+
+    gpio_init(params->gpio, GPIO_OUT);


Suggested change

gpio_init(params->gpio, GPIO_OUT);

if (params->gpio != GPIO_UNDEF) {

gpio_init(params->gpio, GPIO_OUT);

}

The sensor will still work if the shutdown pin is not connected / connected to ground and some platforms will crash if you try to initialize / access GPIO_UNDEF.

benpicco · 2019-11-29T08:51:42Z

drivers/apds9007/apds9007.c

+
+void apds9007_set_active(const apds9007_t *dev)
+{
+    gpio_write(dev->p.gpio, 0);


benpicco · 2019-11-29T09:21:40Z

drivers/apds9007/include/apds9007_params.h

+ * @{
+ */
+#ifndef APDS9007_PARAM_GPIO
+#define APDS9007_PARAM_GPIO     GPIO_PIN(PA,6)


GPIO_UNDEF would also be a good default here.

stale · 2020-06-01T11:34:53Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

Hyungsin force-pushed the forupstream_apds9007 branch 3 times, most recently from 12317bb to a7a0a9a Compare April 20, 2018 00:05

Hyungsin mentioned this pull request Apr 24, 2018

board: add hamilton board support #9013

Merged

tcschmidt requested a review from kYc0o June 21, 2018 11:30

aabadie requested changes Jul 3, 2018

View reviewed changes

Hyungsin force-pushed the forupstream_apds9007 branch 2 times, most recently from 79ba77e to 5b05a33 Compare July 3, 2018 07:24

aabadie requested changes Jul 3, 2018

View reviewed changes

drivers/apds9007/apds9007_saul.c Outdated Show resolved Hide resolved

Hyungsin force-pushed the forupstream_apds9007 branch 4 times, most recently from 74e52c2 to b162ffe Compare July 3, 2018 07:56

Hyungsin force-pushed the forupstream_apds9007 branch 2 times, most recently from 38d6acc to 6f63efd Compare July 3, 2018 17:37

miri64 added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: drivers Area: Device drivers labels Oct 17, 2018

PeterKietzmann added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 5, 2019

PeterKietzmann added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 5, 2019

danpetry added the State: waiting for other PR State: The PR requires another PR to be merged first label Mar 20, 2019

stale bot added the State: stale State: The issue / PR has no activity for >185 days label Nov 28, 2019

benpicco removed the State: waiting for other PR State: The PR requires another PR to be merged first label Nov 28, 2019

stale bot removed the State: stale State: The issue / PR has no activity for >185 days label Nov 28, 2019

Hyungsin closed this Nov 28, 2019

Hyungsin force-pushed the forupstream_apds9007 branch from cfc0dcb to c68470f Compare November 28, 2019 23:21

Hyungsin deleted the forupstream_apds9007 branch November 28, 2019 23:28

Hyungsin mentioned this pull request Nov 28, 2019

drivers: add driver for APDS9007 illuminance sensor #12841

Closed

Hyungsin reopened this Nov 28, 2019

Hyungsin force-pushed the forupstream_apds9007 branch from 57f07b0 to 1237d00 Compare November 29, 2019 08:16

drivers: add driver for APDS9007 illuminance sensor

1496634

Hyungsin force-pushed the forupstream_apds9007 branch from 1237d00 to 1496634 Compare November 29, 2019 08:29

benpicco reviewed Nov 29, 2019

View reviewed changes

stale bot added the State: stale State: The issue / PR has no activity for >185 days label Jun 1, 2020

stale bot closed this Jul 2, 2020

Conversation

Hyungsin commented Apr 19, 2018 • edited by danpetry Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dependencies

Uh oh!

aabadie left a comment

Choose a reason for hiding this comment

Uh oh!

aabadie commented Jul 3, 2018

Uh oh!

Hyungsin commented Jul 3, 2018

Uh oh!

aabadie left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Hyungsin commented Jul 3, 2018

Uh oh!

PeterKietzmann commented Mar 5, 2019

Uh oh!

Hyungsin commented Mar 15, 2019

Uh oh!

PeterKietzmann commented May 22, 2019

Uh oh!

ghost commented May 24, 2019

Uh oh!

jcarrano commented May 27, 2019

Uh oh!

stale bot commented Nov 28, 2019

Uh oh!

benpicco commented Nov 28, 2019

Uh oh!

Hyungsin commented Nov 28, 2019

Uh oh!

benpicco left a comment

Choose a reason for hiding this comment

Uh oh!

benpicco Nov 29, 2019

Choose a reason for hiding this comment

Uh oh!

benpicco Nov 29, 2019

Choose a reason for hiding this comment

Uh oh!

benpicco Nov 29, 2019

Choose a reason for hiding this comment

Uh oh!

benpicco Nov 29, 2019

Choose a reason for hiding this comment

Uh oh!

stale bot commented Jun 1, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Hyungsin commented Apr 19, 2018 •

edited by danpetry

Loading

aabadie left a comment •

edited

Loading