pkg/semtech_loramac: handle non OK mcps confirm messages#8982
Merged
jia200x merged 2 commits intoRIOT-OS:masterfrom May 8, 2018
Merged
pkg/semtech_loramac: handle non OK mcps confirm messages#8982jia200x merged 2 commits intoRIOT-OS:masterfrom
jia200x merged 2 commits intoRIOT-OS:masterfrom
Conversation
aabadie
added
Type: enhancement
aabadie
added
the
CI: ready for build
aabadie
changed the title
aabadie
changed the title
aabadie
changed the title
aabadie
changed the title
aabadie
changed the title
Member
|
Ran some tests on my side, OTAA still works as expected and it also fix some issues I encounter before like shell stucks after sending a message if public : off or class : C. Now I cannot block the shell (at least in OTAA, no clue about ABP). |
Member
|
Seems like I have the same issue as @jia200x with ABP : |
aabadie
force-pushed
the
pr/pkg/semtech_loramac_mcps_fail
branch
from
70fa6c1 to
ef76c3e
Compare
Contributor
Author
|
@dylad can you try again ? I rebased the branch on the latest master which should contain the fix for "mac is busy". |
Member
|
Indeed now it works with ABP too ! @jia200x does it solve your issue too ? |
Member
|
This solves the blocked shell issue for me. Good! |
aabadie
added
State: waiting for other PR
aabadie
force-pushed
the
pr/pkg/semtech_loramac_mcps_fail
branch
from
ef76c3e to
7e2f5cf
Compare
Contributor
Author
Member
|
Perfect! Let's wait Murdock |
Contributor
Author
|
@jia200x, all checks have passed :) |
jia200x
approved these changes
May 8, 2018
Member
|
@dylad are you OK with this PR? |
Member
|
@jia200x I'm fine with this PR. |
Member
|
Great! Then ACK&GO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is built on top of #8798 and #8639 and provides a fallback when no OK MCPS confirm message is received from the network after a TX.
It doesn't solve the fact that no message can be received when using ABP activation but at least it prevents the mac thread from being stuck forever.
For simplicity, non OK status are all treated as error (so we don't distinguish all the cases). See here for more information.
Issues/PRs references
Based on
#8798and#8639