Skip to content

cpu/atmega_common: remove useless periph file guard#8959

Merged
kYc0o merged 1 commit intoRIOT-OS:masterfrom
aabadie:pr/cpu/guard_atmega_common
May 22, 2018
Merged

cpu/atmega_common: remove useless periph file guard#8959
kYc0o merged 1 commit intoRIOT-OS:masterfrom
aabadie:pr/cpu/guard_atmega_common

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented Apr 16, 2018

Contribution description

This PR partially addresses #7981 with atmega cpus family

Issues/PRs references

#7981

@aabadie aabadie added Platform: AVR Platform: This PR/issue effects AVR-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 16, 2018
@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented May 15, 2018

Maybe @kYc0o would be interested by reviewing this one ?

@kYc0o kYc0o self-assigned this May 15, 2018
@kYc0o kYc0o added this to the Release 2018.07 milestone May 15, 2018
@mali
Copy link
Copy Markdown
Contributor

mali commented May 22, 2018

Test OK with Uno board

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented May 22, 2018

Thanks for testing @mali !
@kYc0o, do you ACK ?

Copy link
Copy Markdown
Contributor

@kYc0o kYc0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on arduino-mega2560. ACK.

@kYc0o kYc0o merged commit 8ab9081 into RIOT-OS:master May 22, 2018
@aabadie aabadie deleted the pr/cpu/guard_atmega_common branch June 1, 2018 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: AVR Platform: This PR/issue effects AVR-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants