Skip to content

pkg/semtech-loramac: fix tx_power get/set functions#8835

Closed
aabadie wants to merge 1 commit intoRIOT-OS:masterfrom
aabadie:pr/pkg/semtech-loramac_tx_power
Closed

pkg/semtech-loramac: fix tx_power get/set functions#8835
aabadie wants to merge 1 commit intoRIOT-OS:masterfrom
aabadie:pr/pkg/semtech-loramac_tx_power

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented Mar 26, 2018

Contribution description

This PR fixes the issue reported in this comment

Using MIB_CHANNELS_TX_POWER has no effect on the MAC. The fix simply consists in using MIB_CHANNELS_DEFAULT_TX_POWER instead.

Issues/PRs references

comment raised while reviewing #8798

@aabadie aabadie added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: LoRa Area: LoRa radio support labels Mar 26, 2018
@aabadie aabadie requested a review from dylad March 26, 2018 10:50
@aabadie aabadie mentioned this pull request Mar 26, 2018
Merged
@dylad
Copy link
Copy Markdown
Member

dylad commented Mar 26, 2018

@aabadie This PR doesn't solved the issue or maybe I'm doing something wrong...

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Mar 26, 2018

This PR doesn't solved the issue or maybe I'm doing something wrong

Weird, I tested it and it was working. I'll give another try.

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Mar 26, 2018

Just tested it again and I think I understand your problem: in EU868 all tx power modes cannot be used see this enum => only tx power indexes from 0 to 7 are supported.

@dylad
Copy link
Copy Markdown
Member

dylad commented Mar 26, 2018

Oh so index 0 stand for 20 dB if supported and 1 -> 14 dB right ?
I thought you have to set the value in dB unit so I was trying around 10 - 14 dB ...
I'll give it another shot

@dylad
Copy link
Copy Markdown
Member

dylad commented Mar 26, 2018

I re test with and without, it works and it was working before
Sorry, I should have check the required values before reporting an non-existent issue.

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Mar 26, 2018

I should have check the required values before reporting an non-existent issue.

no problem, this shows that the documentation is not perfect.

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Mar 26, 2018

I re test with and without, it works and it was working before

Just understood this. And rechecked the loramac-node code: this PR is useless IMHO. I think we can close it. Do you agree @dylad ?

@dylad
Copy link
Copy Markdown
Member

dylad commented Mar 26, 2018

@aabadie yes we can close this. Sorry about that...

@aabadie aabadie closed this Mar 26, 2018
@aabadie aabadie deleted the pr/pkg/semtech-loramac_tx_power branch December 28, 2018 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dylad dylad Awaiting requested review from dylad

Assignees

No one assigned

Labels

Area: LoRa Area: LoRa radio support CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aabadie @dylad