Skip to content

pkg*: replace curly braces by parenthesis in makefiles#8815

Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom
aabadie:pr/pkg/cleanup_makefile
Mar 22, 2018
Merged

pkg*: replace curly braces by parenthesis in makefiles#8815
aabadie merged 1 commit intoRIOT-OS:masterfrom
aabadie:pr/pkg/cleanup_makefile

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented Mar 22, 2018

Contribution description

This PR simply use the right way of accessing variables in makefiles, as suggested in this comment.

This PR only addresses the packages makefiles, but using git grep, there are other places in the code that need to be addressed as well.

Issues/PRs references

@aabadie aabadie added Area: build system Area: Build system Area: pkg Area: External package ports Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 22, 2018
Copy link
Copy Markdown
Member

@jnohlgard jnohlgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@aabadie aabadie merged commit 7f91bfe into RIOT-OS:master Mar 22, 2018
@aabadie aabadie deleted the pr/pkg/cleanup_makefile branch June 8, 2018 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: build system Area: Build system Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants