cpu/stm32l4: add adc implementation#8804
Merged
MichelRottleuthner merged 1 commit intoRIOT-OS:masterfrom Jul 6, 2018
Merged
Conversation
MichelRottleuthner
added
Type: enhancement
kaspar030
requested changes
Mar 28, 2018
cpu/stm32l4/periph/adc.c
Outdated
| /** | ||
| * @brief Allocate locks for all three available ADC devices | ||
| */ | ||
| static mutex_t locks[] = { |
Contributor
There was a problem hiding this comment.
static mutex_t locks[ADC_DEVS]; will have the same effect.
Contributor
There was a problem hiding this comment.
I allowed myself to directly address your comment @kaspar030. Tested with nucleo-l476 and still works.
Contributor
|
Does anyone have an stm32l4 board for testing? |
Contributor
me, but I won't be able to test before next tuesday unfortunately |
aabadie
added
the
CI: ready for build
aabadie
force-pushed
the
pr_stm32l4_add_adc
branch
from
d271a2a to
511a6be
Compare
aabadie
added
the
Type: new feature
12 tasks
Member
|
Test seems o.k.. Are the change requests satisfied @kaspar030 ? Can we proceed with this? |
kaspar030
approved these changes
Jun 19, 2018
Contributor
|
needs rebase |
MichelRottleuthner
force-pushed
the
pr_stm32l4_add_adc
branch
from
511a6be to
31d49db
Compare
MichelRottleuthner
force-pushed
the
pr_stm32l4_add_adc
branch
from
31d49db to
e4c405d
Compare
Contributor
Author
|
Murdock spits out some unrelated error regarding xtimer_now64_continuity test. @kaspar030: do you have an idea where this comes from? |
MichelRottleuthner
added
CI: ready for build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Adds implementation for ADC on stm32l4. Currently this only includes configuration for nucleo-l476, and only for the analog pins of the arduino header.
Issues/PRs references
Could make sense to merge this with #7277.
I didn't base it on that PR as it doesn't seem working completely for now, and the ADCs on the L4 are actually quite a bit different to initialize.