make: always set -Wno-implicit-fallthrough#8603
Conversation
kaspar030
added
Area: build system
|
Can't we make a push on the fixing PRs instead? #8265 |
Ah, wasn't aware of that PR. Not much to go it seems! Thing is, every murdock slave that (for whatever reason) restarts now will pull the newest container from docker hub, which currently contains ARM gcc 7. I can manually disable the one worker that has gcc7 now, but it would only be a matter of time until another one updates. Pinning gcc6 into the Dockerfile, no idea how to do that. |
|
I did a local compile check and there are some places which have not been reported yet, so I guess we need to disable the errors for now. We do need to bring fixing the errors to a high priority to avoid more warnings slipping past while the errors are disabled. |
jnohlgard
left a comment
jnohlgard
left a comment
There was a problem hiding this comment.
ACK, as a temporary measure.
Please provide such a PR once you have updated to CI workers |
2 participants
Contribution description
gcc 7 introduced a new warning for uncommented implicit switch/case fallthroughs. As we enable all plus extra warnings, gcc 7 stumbles over a couple of those in our codebase.
There have been numerous PR's fixing remaining fallthrough warnings, mostly in packages. Still, many are left.
Ideally we'd fix them all before CI is switching to gcc 7. Unfortunately, somehow the ppa's used within the RIOT Dockerfile now default to a newer gcc7 arm toolchain, thus forcing our hand...
I propose just disabling the warning for now, globally, as this PR does.