Skip to content

boards: stk3600: add support (v2)#8585

Merged
basilfx merged 3 commits intoRIOT-OS:masterfrom
basilfx:feature/efm32_stk3600_v2
Feb 22, 2018
Merged

boards: stk3600: add support (v2)#8585
basilfx merged 3 commits intoRIOT-OS:masterfrom
basilfx:feature/efm32_stk3600_v2

Conversation

@basilfx
Copy link
Copy Markdown
Member

@basilfx basilfx commented Feb 17, 2018

Contribution description

This PR add supports for the Silicon Labs STK3600. The files are very similar to the SLTB001a and STK3700 already supported.

For convenience, this is the diff between STK3700 and STK3600 board files.

Issues/PRs references

#8520

@basilfx basilfx added Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 17, 2018
@basilfx basilfx force-pushed the feature/efm32_stk3600_v2 branch from f828dab to 9b1af9d Compare February 21, 2018 18:17
@@ -0,0 +1,72 @@
# This file is automatically generated, and should not be changed. There is
# propbably little reason to edit this file anyway, since it should already
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can deduce the typo in 'probably' is also automatically generated :)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in #8618.

@jia200x
Copy link
Copy Markdown
Member

jia200x commented Feb 22, 2018

Hi @basilfx.
Maybe opening a new PR for the vendor header files and cpu related stuff? Could help with the reviews

@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Feb 22, 2018

@jia200x usually we don't review the vendor headers (or at least is what I got when we disabled all the static checks for vendor headers, maybe I'm mistaken), since they are huge and not written by the contributor of a new board. I don't know if there are cases where there are bugs there but I'd say that if so, we should patch them in subsequent PRs (which usually means to update them with a newer version).

Copy link
Copy Markdown
Contributor

@kYc0o kYc0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK.

If you want to correct the typo found by @jia200x it would be great!

@basilfx
Copy link
Copy Markdown
Member Author

basilfx commented Feb 22, 2018

I'll fix that in another PR, since I can do that for multiple files (other EFM32 families).

ACK?

@basilfx basilfx merged commit e092144 into RIOT-OS:master Feb 22, 2018
@jia200x
Copy link
Copy Markdown
Member

jia200x commented Feb 23, 2018

@jia200x usually we don't review the vendor headers (or at least is what I got when we disabled all the static checks for vendor headers, maybe I'm mistaken), since they are huge and not written by the contributor of a new board. I don't know if there are cases where there are bugs there but I'd say that if so, we should patch them in subsequent PRs (which usually means to update them with a newer version).

Ok! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants