periph_rtt: remove RTT_NUMOF guard and init from periph_common#8543
Merged
vincent-d merged 2 commits intoRIOT-OS:masterfrom Jul 10, 2018
Merged
periph_rtt: remove RTT_NUMOF guard and init from periph_common#8543vincent-d merged 2 commits intoRIOT-OS:masterfrom
vincent-d merged 2 commits intoRIOT-OS:masterfrom
Conversation
vincent-d
added
Type: cleanup
smlng
approved these changes
Feb 12, 2018
Member
smlng
left a comment
smlng
left a comment
There was a problem hiding this comment.
Looks good to me @haukepetersen can you confirm?
Member
Author
|
Do we want to wait for @haukepetersen ? Maybe @gebart could take a look as well, for mulle part? |
jnohlgard
reviewed
Mar 5, 2018
Member
jnohlgard
left a comment
jnohlgard
left a comment
There was a problem hiding this comment.
Change looks fine in theory. Did not yet test on real hardware
Member
Author
|
Can we merge this one, or should we still wait? |
Member
|
I will have to update EFM32: it uses the same hardware peripheral for RTC and RTT, so it should throw an error if both are selected. |
Member
Author
|
Since #8890 is merged, we can merge this too. Go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This align header with other periph (i.e. removes
RTT_NUMOFguard which is not needed anymore).I also added a call to
rtt_init()fromperiph_init()but I'm not sure if it will work on every platform correctly. For instance, mulle seems to need to callrtt_init()earlier in the boot process.So I can still remove the second commit if we don't agree on it.
Issues/PRs references
None