Skip to content

boards: stk3700: add support (v2)#8520

Merged
basilfx merged 3 commits intoRIOT-OS:masterfrom
basilfx:feature/efm32_stk3700_v2
Feb 16, 2018
Merged

boards: stk3700: add support (v2)#8520
basilfx merged 3 commits intoRIOT-OS:masterfrom
basilfx:feature/efm32_stk3700_v2

Conversation

@basilfx
Copy link
Copy Markdown
Member

@basilfx basilfx commented Feb 5, 2018

Contribution description

This PR add supports for the Silicon Labs STK3700. In this new version, common files have been moved to boards/common/silabs.

The files are very similar to the SLTB001a already supported.

Issues/PRs references

Made possible by #8139, successor of #8297, with recommendations of #8295.

@basilfx basilfx added Platform: ARM Platform: This PR/issue effects ARM-based platforms CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: boards Area: Board ports labels Feb 5, 2018
@basilfx basilfx requested a review from kYc0o February 5, 2018 22:56
This was referenced Feb 5, 2018
Closed
Closed
@basilfx basilfx added CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 6, 2018
@basilfx basilfx force-pushed the feature/efm32_stk3700_v2 branch from aeafd56 to 4eda967 Compare February 6, 2018 22:31
kYc0o
kYc0o requested changes Feb 7, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@kYc0o kYc0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK so far, I don't know if I'm supposed to test ALL peripherals, if so, it will take long time before this gets in.

Are the changes to sltb001a part of this PR? I'd say either remove them or make another PR with those changes, unless they're strictly necessary.

Another small thing, xtimer_drift drifts increasingly and never corrects... is it normal?

@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Feb 7, 2018

BTW, I tested and works very good so far, besides the xtimer config which may need some tuning.

@basilfx basilfx mentioned this pull request Feb 7, 2018
Merged
@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Feb 14, 2018

Well, I think this one needs rebase :)

@basilfx basilfx force-pushed the feature/efm32_stk3700_v2 branch from 4eda967 to 7844f90 Compare February 14, 2018 15:03
@basilfx
Copy link
Copy Markdown
Member Author

basilfx commented Feb 14, 2018

Rebased and adapted to boards/common/silabs.

@basilfx basilfx force-pushed the feature/efm32_stk3700_v2 branch 2 times, most recently from 46b97ac to 10f89a4 Compare February 14, 2018 22:52
kYc0o
kYc0o reviewed Feb 15, 2018
View reviewed changes
boards/stk3700/board.c
@@ -0,0 +1,32 @@
/*
* Copyright (C) 2015-2018 Freie Universität Berlin
Copy link
Copy Markdown
Contributor

@kYc0o kYc0o Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say the copyright belongs to you too?

Copy link
Copy Markdown
Member Author

@basilfx basilfx Feb 15, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly: the file was originally copied from the SLWSTK6220 by @haukepetersen.

Copy link
Copy Markdown
Contributor

@kYc0o kYc0o Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok no problem then.

@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Feb 15, 2018

Besides the "missing" (I'd say optional) copyrights I found a non working RTC. If you want to fix it is OK, otherwise you can remove it from the list of the provided features and work on it later. This way at least this PR is merged.

@kYc0o kYc0o added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable labels Feb 15, 2018
@basilfx basilfx force-pushed the feature/efm32_stk3700_v2 branch 2 times, most recently from 4924287 to d3fc11f Compare February 15, 2018 20:03
@basilfx basilfx mentioned this pull request Feb 15, 2018
Merged
@basilfx
Copy link
Copy Markdown
Member Author

basilfx commented Feb 15, 2018

Created #8572 to address RTC and ADC issue. Will wait for that one.

@basilfx basilfx added State: waiting for other PR State: The PR requires another PR to be merged first and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 15, 2018
@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Feb 16, 2018

Small rebase needed again 😅

@basilfx basilfx added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Feb 16, 2018
@basilfx basilfx removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 16, 2018
@basilfx basilfx force-pushed the feature/efm32_stk3700_v2 branch from d3fc11f to 6f39d67 Compare February 16, 2018 12:57
@basilfx basilfx added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 16, 2018
@basilfx
Copy link
Copy Markdown
Member Author

basilfx commented Feb 16, 2018

Rebased.

kYc0o
kYc0o approved these changes Feb 16, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@kYc0o kYc0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@basilfx basilfx merged commit 9d55472 into RIOT-OS:master Feb 16, 2018
This was referenced Feb 17, 2018
Merged
Merged
This was referenced Mar 16, 2018
Merged
Merged
Merged
@basilfx basilfx mentioned this pull request Mar 25, 2018
Closed
@basilfx basilfx mentioned this pull request Oct 1, 2019
Merged
@basilfx basilfx deleted the feature/efm32_stk3700_v2 branch January 9, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kYc0o kYc0o kYc0o approved these changes

Assignees

No one assigned

Labels

Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@basilfx @kYc0o