boards/make: use shared makefiles for serial port selection#8484
Closed
haukepetersen wants to merge 4 commits intoRIOT-OS:masterfrom
Closed
boards/make: use shared makefiles for serial port selection#8484haukepetersen wants to merge 4 commits intoRIOT-OS:masterfrom
haukepetersen wants to merge 4 commits intoRIOT-OS:masterfrom
Conversation
haukepetersen
added
Type: enhancement
Member
|
In my opinion this is only moving the problem of wrong TTY selection from one place to another. I would prefer using #7695 to provide a centralized USB UART configuration instead of these static configurations. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR introduces two shared convenience makefiles for the most common serial configurations. Though I adapted the most obvious boards, there are others that can potentially also benefit from the new makefiles. I suggest to adapt other boards on a 'when we get to it' basis.
Issues/PRs references
#8475 gave me the idea for this...