mips: Correct usage of USEMODULE#8360
Merged
smlng merged 1 commit intoRIOT-OS:masterfrom Jan 15, 2018
Merged
Conversation
neiljay
added
CI: ready for build
smlng
suggested changes
Jan 15, 2018
Member
smlng
left a comment
smlng
left a comment
There was a problem hiding this comment.
looks good, just a very minor thing my IDE and GitHub complained about. Otherwise this looks good to merge.
|
|
||
| USEMODULE += periph_common | ||
| USEMODULE += periph_hwrng | ||
| USEMODULE += periph_common No newline at end of file |
Contributor
|
Looks good to me too. I did not tested has I have no boards, just reviewed the changes. I would just like an addition in the commit message to mention that before I added a temporary PR to run murdock and verify it makes #8227 build correctly (Build passed https://ci.riot-os.org/RIOT-OS/RIOT/8361/7a510c9a6f68b2b0b743da4f0f588637ccd17499/output.html). |
cladmi
approved these changes
Jan 15, 2018
In CPU definitions we should not be explicilty naming peripheral modules to use via USEMODULE (one should use FEATURES_PROVIDED instead). Plus add missing cpu_init() and periph_init() methods. This commit removes periph_hwrng support from the pic32mx cpu builds as pic32mx does not have hwrng only pic32mz does.
neiljay
force-pushed
the
pr/correct_usage_of_features_on_mips
branch
from
794dba2 to
e297a71
Compare
Contributor
Author
smlng
approved these changes
Jan 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CPU definitions we should not be explicitly naming peripheral modules to use
via USEMODULE (one should use FEATURES_PROVIDED instead).
Plus add missing cpu_init() and periph_init() methods.
This addresses some issues in #8052