drivers/kw2xrf: finish ongoing transmission before sending next frame#8304
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Jan 9, 2018
Merged
Conversation
PeterKietzmann
added
Type: bug
PeterKietzmann
force-pushed
the
pr_drivers_kw2x_txbusy
branch
from
b28ba5e to
73a2810
Compare
PeterKietzmann
added
CI: ready for build
Member
|
I can't test on actual hardware because I don't have a phytec board, but I will do a review |
Member
|
tested with 2 PhyNodes: works like charm. Even with remote-rev there is an improvement, but cannot get beyond 90B pings -> buts a problem with the remotes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
As described in below referenced issues, the KW2XRF driver currently does not wait for ongoing transmissions to finish before sending a next frame. If the device is busy, the second frame will simply be ignored. Problems usually occur with 6LoWPAN-fragmented IPv6 packets. This PR provides a fix. Now
ping6between a Phytec node an Atmel node with payloads up to 900.@gebart I added you as author because this is actually your solution from #7107. D'accord?
Issues/PRs references
(Partly) fixes #4822; relates to #7474; fix taken from #7107