Conversation
|
One thing I just noticed: when adding all the SiLabs boards, it seems to me that there are some parts of the board configuration that basically pop up in each of the PRs (e.g. LED macros, feature definitions, clock config?, more?). I think it would make sense to factor those parts out into a shared board folder, e.g. something like You have probably the better overview on the similarities of all those boards, so do you think this is a sensible thing to do? |
|
Currently, I only think the common features (or, at least very common) are:
What isn't (or what would cost more preprocessor lines):
If I would generalize it, it is easier to open one PR for all the boards IMHO. Would that be OK? Or could we first accept the PRs (than we don't get a long list of vendor files in the commits)? (p.s. the build error is related to a bug in pwm.c of the EFM32 code). |
|
Closing this one for a common approach that I soon will PR. |
|
Second attempt in #8520. I tried to generalize as much as possible, but limited it to board controller, AEM and PIC (SLTB001a only). |
Contribution description
This PR add supports for the Silicon Labs STK3200.
The files are very similar to the SLTB001a already supported
Issues/PRs references
Made possible by #8139.