makefiles/modules.inc.mk: remove setting deprecated FEATURE_PERIPH_ macros#8292
Merged
jnohlgard merged 1 commit intoRIOT-OS:masterfrom Feb 9, 2018
Merged
Conversation
cladmi
added
Type: cleanup
`#ifdef FEATURE_PERIPH_NAME` usage should now be replaced by `#ifdef MODULE_PERIPH_NAME`. This deprecation was started by pull requests RIOT-OS#8226 and RIOT-OS#8227.
cladmi
force-pushed
the
pr/deprecated/feature_macros
branch
from
78a308f to
e554a19
Compare
cladmi
added
CI: ready for build
jnohlgard
approved these changes
Feb 1, 2018
Member
jnohlgard
left a comment
jnohlgard
left a comment
There was a problem hiding this comment.
Untested ACK. Verified with git grep that there are no references to FEATURE_ macros in the tree other than this removed line
Member
|
Looks good, did some more digging around the sources and I can't find any users of the FEATURE_ macros anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes setting the
FEATURES_PERIPH_macros as they are completely unused and said deprecated.There will be no reference after #8227 which was even set manually.
Was cleaned up also by: #8226