drivers/sx127x: add functions required for loramac#8261
Merged
dylad merged 1 commit intoRIOT-OS:masterfrom Dec 14, 2017
Merged
Conversation
aabadie
added
Type: cleanup
aabadie
force-pushed
the
pr/drivers_sx17X_missing_functions
branch
3 times, most recently
from
a16ce81 to
e9374e5
Compare
Contributor
Author
|
Maybe @dylad you can have a look at this one ? |
Member
|
Sure ! I already assign myself :) |
Contributor
Author
Thanks ! I missed that. |
Merged
dylad
reviewed
Dec 14, 2017
Member
dylad
left a comment
dylad
left a comment
There was a problem hiding this comment.
Few issues within comments otherwise looks good.
I'll ACK once fix.
drivers/include/sx127x.h
Outdated
| /** | ||
| * @brief Checks that channel is free with specified RSSI threshold. | ||
| * | ||
| * @param[in] dev The sx1276 device structure pointer |
Member
There was a problem hiding this comment.
sx127x would be better (same for the function beneath)
drivers/include/sx127x.h
Outdated
| * | ||
| * @param[in] dev The sx1276 device structure pointer | ||
| * @param[in] freq channel RF frequency | ||
| * @param[in] rssi_thresh RSSI treshold |
aabadie
force-pushed
the
pr/drivers_sx17X_missing_functions
branch
from
e9374e5 to
b543d0b
Compare
Contributor
Author
|
Done and directly squashed |
dylad
approved these changes
Dec 14, 2017
Member
dylad
left a comment
dylad
left a comment
There was a problem hiding this comment.
ACK I'm fine with the changes !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds a missing function in the SX127x driver that is required for LoRaMAC. Plus it adds a missing definition for a function already present in the driver.
There's also a small cleanup in one debug output.
Issues/PRs references
refs #7331