unittests: fix failed assertion caused by priority_pktqueue#8259
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Dec 14, 2017
Merged
unittests: fix failed assertion caused by priority_pktqueue#8259miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64 merged 1 commit intoRIOT-OS:masterfrom
Conversation
smlng
added
Type: enhancement
smlng
force-pushed
the
fix/unittests/priority_pktqueue
branch
from
2603526 to
412027f
Compare
smlng
added
the
CI: ready for build
smlng
force-pushed
the
fix/unittests/priority_pktqueue
branch
from
412027f to
91667b0
Compare
smlng
force-pushed
the
fix/unittests/priority_pktqueue
branch
from
91667b0 to
2149411
Compare
Contributor
|
Tested, and looks OK to me. ACK. |
zhuoshuguo
approved these changes
Dec 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Failed assertion due to wrong usage in unittest, was discovered in #8080
Issues/PRs references
fixes a failed assertion in gnrc_packet_buf caused by the priority_pktqueue unites. The assertion fails because the tests calls flush on the queue which removes all nodes and associated packet_snips assuming these snips are in the packet but which they weren't for the test case.