cpu/sam0_common: fix assert in periph/flashpage#8233
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Dec 11, 2017
Merged
Conversation
smlng
added
Type: enhancement
dylad
approved these changes
Dec 11, 2017
Member
dylad
left a comment
dylad
left a comment
There was a problem hiding this comment.
ACK ! Change looks good, I tested on SAML21-XPRO it works but I encountered some issues which are not related to this PR. I'll open an issue about that later.
kaspar030
reviewed
Dec 11, 2017
|
|
||
| /* ensure the length doesn't exceed the actual flash size */ | ||
| assert(((uint8_t*)target_addr + len) < | ||
| assert(((unsigned)target_addr + len) < |
Contributor
There was a problem hiding this comment.
shouldn't this be uintptr_t?
Member
There was a problem hiding this comment.
Well, this is another possibility.
Member
Author
There was a problem hiding this comment.
I made it consistent with other asserts in this file, so either leave as is (which works) or change all assert to use uintptr_t. But I guess than we can grep all-over RIOT to fix that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needed for #8080, fixes an error with comparison of pointer and int.