Skip to content

saml21: Update FEATURE_PERIPH_PM -> MODULE_PERIPH_PM#8226

Merged
dylad merged 1 commit intoRIOT-OS:masterfrom
jnohlgard:pr/saml21-feature_periph
Dec 8, 2017
Merged

saml21: Update FEATURE_PERIPH_PM -> MODULE_PERIPH_PM#8226
dylad merged 1 commit intoRIOT-OS:masterfrom
jnohlgard:pr/saml21-feature_periph

Conversation

@jnohlgard
Copy link
Copy Markdown
Member

The saml21 contained a preprocessor check for the deprecated FEATURE_PERIPH_PM define.

@jnohlgard jnohlgard added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 8, 2017
@jnohlgard jnohlgard added this to the Release 2018.01 milestone Dec 8, 2017
Copy link
Copy Markdown
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un-tested ACK.
I'm pretty sure this change is good but I can run some tests tomorrow to be sure if you want.

@jnohlgard
Copy link
Copy Markdown
Member Author

@dylad I don't have any saml21 boards, so if you have access to any it would be great if you could test it.

@dylad
Copy link
Copy Markdown
Member

dylad commented Dec 8, 2017

Works fine on SAML21-XPRO !
Let's merge it.

@dylad dylad merged commit 2320c26 into RIOT-OS:master Dec 8, 2017
cladmi added a commit to cladmi/RIOT that referenced this pull request Jan 18, 2018
`#ifdef FEATURE_PERIPH_NAME` usage should now be replaced by
`#ifdef MODULE_PERIPH_NAME`.

This deprecation was started by pull requests RIOT-OS#8226 and RIOT-OS#8227.
@jnohlgard jnohlgard deleted the pr/saml21-feature_periph branch February 14, 2018 07:10
panail pushed a commit to panail/RIOT that referenced this pull request Oct 29, 2018
`#ifdef FEATURE_PERIPH_NAME` usage should now be replaced by
`#ifdef MODULE_PERIPH_NAME`.

This deprecation was started by pull requests RIOT-OS#8226 and RIOT-OS#8227.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants