gnrc_ipv6_nib: Allow l2addr == NULL for gnrc_ipv6_nib_nc_set()#8179
Merged
smlng merged 1 commit intoRIOT-OS:masterfrom Nov 29, 2017
Merged
gnrc_ipv6_nib: Allow l2addr == NULL for gnrc_ipv6_nib_nc_set()#8179smlng merged 1 commit intoRIOT-OS:masterfrom
smlng merged 1 commit intoRIOT-OS:masterfrom
Conversation
miri64
added
Process: API change
Member
|
For what reason would a protocol (SLIP), that doesn't need link layer addresses, need the neighbor cache for? |
Member
|
🤔 |
Member
Author
|
To allow for the right interface to be identified in a multi-interface scenario e.g.. |
Member
Author
|
Anyhow... The shell command allows for it, the NIB internals allow for it (where it makes even more sense to have no L2 address for INCOMPLETE state e.g.), just this single assert (and the missing check before the memcpy()) put a damper on NIB-NC. |
Member
|
Thanks for the explanation, the situation makes sense :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link-layer addresses are allowed to be NULL (e.g. for SLIP), so this PR fixes that for the NIB-NC API.