Skip to content

cpu, efm32_common: fix sign-compare error in flashpage#8175

Merged
smlng merged 1 commit intoRIOT-OS:masterfrom
smlng:cpu/efm32/fix_sign_compare
Nov 29, 2017
Merged

cpu, efm32_common: fix sign-compare error in flashpage#8175
smlng merged 1 commit intoRIOT-OS:masterfrom
smlng:cpu/efm32/fix_sign_compare

Conversation

@smlng
Copy link
Copy Markdown
Member

@smlng smlng commented Nov 29, 2017

don't know why or how, but this slipped through when merging #7919, but popped up in Murdock of #8080 (see here)

@smlng smlng added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 29, 2017
@basilfx
Copy link
Copy Markdown
Member

basilfx commented Nov 29, 2017

ACK. Tested on sltb001a.

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Nov 29, 2017

compile tests with BOARD=ikea-tradfri and tests/periph_flashpage which works with this PR but fails on master

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Nov 29, 2017

@basilfx, as you've been: thx for testing (so quickly)!

@smlng smlng merged commit a6c2558 into RIOT-OS:master Nov 29, 2017
@smlng smlng deleted the cpu/efm32/fix_sign_compare branch November 29, 2017 15:14
@aabadie aabadie added this to the Release 2018.01 milestone Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants