sys/net/gnrc: provide lora adaption to netif#8158
sys/net/gnrc: provide lora adaption to netif#8158aabadie wants to merge 1 commit intoRIOT-OS:masterfrom
Conversation
b144441 to
5393b14
Compare
5393b14 to
216990f
Compare
| } | ||
|
|
||
| /* copy the complete payload into the packet buffer */ | ||
| dev->driver->recv(dev, payload->data, pktlen, NULL); |
There was a problem hiding this comment.
Doesn't LoRA has any L2 headers oO (if so, I guess you can use gnrc_netif2_raw after all)?
There was a problem hiding this comment.
(but from what I have seen on some websites, there is a LoRA MHDR)
There was a problem hiding this comment.
LoRa (as used here) is just radio data. LoRaMac has L2 headers.
There was a problem hiding this comment.
Ok, now I need some clarification: Where in the LoRa-Stack is this here to go? Is this just some proof-of-concept that will be insignificant as soon as the real LoRaMAC gnrc_netif layer comes? Is this supposed to go below LoRaMac (which would be possible with GNRC, but why have the extra thread then)? In either case: I am struggling to see the long-term benefit of this PR, but maybe I'm missing something.
There was a problem hiding this comment.
Is this just some proof-of-concept that will be insignificant as soon as the real LoRaMAC gnrc_netif layer comes?
I was more thinking of another netif type for loramac.
In either case: I am struggling to see the long-term benefit of this PR, but maybe I'm missing something.
Or maybe I am missing something (most likely I would say ;) )
There was a problem hiding this comment.
@PeterKietzmann, yes, so I think we can close this one.
|
I think I should move all this in the sx127x driver code instead.and rename the netif create in |
Why? I'm getting more and more confused what you are trying to do with that device. Let's unravel and talk about this first: Is the sx127x module using some proprietary communication scheme like XBee to make LoRa happen or is it expecting ready build LoRaMac (or what ever the link-layer format is called) headers (and yielding them on receive)? If the first is the case: then yes, create a specific adaption layer for sx127x, though from what I see here this could just be |
|
What I want to do is auto initializing the radio driver and being able to send receive packets using Maybe in both cases (raw radio packet or packet via semtech-loramac/rn2xx3 mac) the gnrc_netif_raw could be used ? |
ifconfig (as the name suggests) can only configure an interface...
Yes. |
indeed, I was more thinking at |
|
@aabadie wrote in #8158 (comment)
|
Provide LoRa adaption to the new netif interface.
Follow-up of #7950.