gnrc_ipv6_nib: Remove stray assert() in _handle_aro()#8087
Merged
bergzand merged 1 commit intoRIOT-OS:gnrc_netif2_integration/masterfrom Nov 20, 2017
Merged
Conversation
This assertion doesn't make any sense. The function is called by _copy_and_handle_aro() on a router which causes `nce` to be NULL (because there is no NCE known yet) and then the function called directly after (_reg_addr_upstream()) checks if `nce` might be NULL and creates an NCE if necessary.
miri64
added
Type: bug
This was referenced Nov 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug reported by @cgundogan and @bergzand in IRC.
This assertion doesn't make any sense. The function is called by
_copy_and_handle_aro() on a router which causes
nceto be NULL(because there is no NCE known yet) and then the function called
directly after (_reg_addr_upstream()) checks if
ncemight be NULL andcreates an NCE if necessary.