Skip to content

gnrc_ipv6_nib: make user added default route the primary one#8083

Merged
cgundogan merged 2 commits intoRIOT-OS:gnrc_netif2_integration/masterfrom
miri64:gnrc_ipv6_nib/api/prime-dr
Nov 19, 2017
Merged

gnrc_ipv6_nib: make user added default route the primary one#8083
cgundogan merged 2 commits intoRIOT-OS:gnrc_netif2_integration/masterfrom
miri64:gnrc_ipv6_nib/api/prime-dr

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Nov 19, 2017

This PR ensures that the (last) default route added with gnrc_ipv6_nib_ft_add() is the primary default route. This way the user (or the routing protocol) has full control over which route is the primary one without changing the API syntax (just the semantics).

@miri64 miri64 added Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation GNRC Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 19, 2017
@miri64 miri64 added the State: waiting for other PR State: The PR requires another PR to be merged first label Nov 19, 2017
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 19, 2017

The build only failed the label check.

@kaspar030 👍

@cgundogan
Copy link
Copy Markdown
Member

cgundogan commented Nov 19, 2017

@miri64 looks like I need this PR for the RPL port. Currently (on native), the native instances set default routes to each other because of Router Advertisements (gnrc_networking). I think that messes with RPL ..

@cgundogan cgundogan mentioned this pull request Nov 19, 2017
@cgundogan
Copy link
Copy Markdown
Member

cgundogan commented Nov 19, 2017

make user added default route the primary one

it shouldn't just be the primary one, it also shouldn't be replaced by ND internals? Should we disable Router Advertisements if an actual routing protocol is compiled in?

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 19, 2017

it shouldn't just be the primary one, it also shouldn't be replaced by ND internals? Should we disable Router Advertisements if an actual routing protocol is compiled in?

At least for RPL this might be a good idea in the long run (and as a short term thing as well). But we still don't have a replacement for 6Lo Context Options in RPL, right?

@miri64 miri64 force-pushed the gnrc_ipv6_nib/api/prime-dr branch from 346cb8d to 2f7b55b Compare November 19, 2017 22:36
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 19, 2017

Rebased

@miri64 miri64 removed the State: waiting for other PR State: The PR requires another PR to be merged first label Nov 19, 2017
@cgundogan
Copy link
Copy Markdown
Member

But we still don't have a replacement for 6Lo Context Options in RPL, right?

nope we don't .. I will handle this 6co thing as soon as I'm back. Takes too long for that to be standardized.

Copy link
Copy Markdown
Member

@cgundogan cgundogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 19, 2017

nope we don't .. I will handle this 6co thing as soon as I'm back. Takes too long for that to be standardized.

Awfully! Until then: deactivating RAs is the tiniest thing. You can even do that via ifconfig before starting RPL ;-).

@cgundogan cgundogan added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 19, 2017
@cgundogan
Copy link
Copy Markdown
Member

You can even do that via ifconfig before starting RPL ;-).

do you offer any compile time config for that? (:

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 19, 2017

do you offer any compile time config for that? (:

Not yet, but basically every router in a 6LoWPAN has that flag deactivated, as per RFC 6775, except for the border router (which should be the RPL root) so it isn't that tedious to deactivate it manually ;-). But will think about that config thingy :-).

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 19, 2017

Also need to investigate, what a missing router advertisement means for address registration. Probably won't work anymore :-/.

@cgundogan cgundogan merged commit 21a5561 into RIOT-OS:gnrc_netif2_integration/master Nov 19, 2017
@miri64 miri64 deleted the gnrc_ipv6_nib/api/prime-dr branch November 19, 2017 22:52
@aabadie aabadie added this to the Release 2018.01 milestone Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants