Skip to content

gnrc_ipv6_nib: fix gnrc_netif dependency#8082

Merged
cgundogan merged 1 commit intoRIOT-OS:gnrc_netif2_integration/masterfrom
miri64:gnrc_ipv6_nib/fix/gnrc_netif_dep
Nov 19, 2017
Merged

gnrc_ipv6_nib: fix gnrc_netif dependency#8082
cgundogan merged 1 commit intoRIOT-OS:gnrc_netif2_integration/masterfrom
miri64:gnrc_ipv6_nib/fix/gnrc_netif_dep

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Nov 19, 2017

GNRC includes this dependency implicitly, but if the NIB is used
isolated (as e.g. in its unittest suite) this dependency is missing.

GNRC includes this dependency implicitly, but if the NIB is used
isolated (as e.g. in its unittest suite) this dependency is missing.
@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) GNRC Area: network Area: Networking labels Nov 19, 2017
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 19, 2017
Copy link
Copy Markdown
Member

@cgundogan cgundogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing wrong with setting the dependency explicitely. ACK

@cgundogan cgundogan merged commit ba77fd5 into RIOT-OS:gnrc_netif2_integration/master Nov 19, 2017
@miri64 miri64 deleted the gnrc_ipv6_nib/fix/gnrc_netif_dep branch November 19, 2017 22:33
@aabadie aabadie added this to the Release 2018.01 milestone Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants