make: enable develhelp for all tests, except minimal by smlng · Pull Request #8080 · RIOT-OS/RIOT

smlng · 2017-11-17T17:59:21Z

factored out from #8029, this PR enables develhelp for all tests except tests/minimal to ensure size comparison.

miri64 · 2017-11-17T22:04:38Z

Please remember to wait with this, until #7925 is merged.

miri64 · 2017-11-27T20:27:14Z

Needs rebase.

smlng · 2017-11-28T09:52:08Z

rebased and squashed

smlng · 2017-11-28T21:22:15Z

rebased

kaspar030

small one

kaspar030 · 2017-11-29T09:23:25Z

tests/conn_can/Makefile


-
-CFLAGS += -DDEVELHELP
-CFLAGS += -DLOG_LEVEL=LOG_ALL


Why change the log level?

unrelated -yes - but having LOG_ALL is inconsistent with all other tests where it is not enabled. So why here, and if we want to have it then it should be set for all tests (and then use Makefile.test_common), or not?

@smlng - because it is another thing to test for. If you keep that line, I can look at the diff and say "I acknowledge that this PR enables DEVELHELP for all tests except minimal". If you remove it, I have to dig through the test to ensure it makes no difference...

I agree having "LOG_ALL" enabled in that test, without comment, is weird. It's just unrelated.

okay, so I leave CFLAGS += -DLOG_LEVEL=LOG_ALL as is - and we may remove it in a separate PR, okay?

kaspar030 · 2017-11-29T09:27:40Z

When you're squashing, maybe somehow change the wording for the tests/minimal commit? As is, it sounds like a change.

smlng · 2017-11-29T09:34:02Z

When you're squashing, maybe somehow change the wording for the tests/minimal commit? As is, it sounds like a change.

well it is a change, or at least an adaption to the new switching method, but what I wanted to make clear (stand out) is that in general DEVELHELP is activated (set in Makefile.test_common) but is disabled here explicitly for reason of size comparison (though you're right: it was that way before)

kaspar030 · 2017-11-29T12:08:26Z

tests/gnrc_netif missing.
please squash!

smlng · 2017-11-29T16:22:49Z

~~needs #8177~~

smlng · 2017-11-29T21:00:29Z

rebased, after #8177 merged now

kaspar030 · 2017-11-30T08:15:25Z

There's still a failed assertion in the unittests?

smlng · 2017-11-30T08:54:47Z

There's still a failed assertion in the unittests?

damn, but its a new one 🤔 I'll see to it ...

smlng · 2017-12-10T15:25:00Z

~~needs #8233~~

kaspar030 · 2017-12-11T21:24:59Z

cpu/sam0_common/periph/flashpage.c


    /* ensure the length doesn't exceed the actual flash size */
-    assert(((uint8_t*)target_addr + len) <
+    assert(((unsigned)target_addr + len) <


shouldn't this be uintptr_t?

smlng · 2017-12-13T20:57:33Z

~~needs #8259~~

to ensure minimal binary size for comparison

smlng · 2017-12-14T16:56:37Z

rebased

smlng · 2017-12-15T10:20:03Z

@kaspar030: Murdock is happy now, and you comments are addressed - I guess.

smlng added Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR State: waiting for other PR State: The PR requires another PR to be merged first labels Nov 17, 2017

smlng requested a review from kaspar030 November 17, 2017 17:59

smlng added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Nov 17, 2017

smlng mentioned this pull request Nov 17, 2017

make: cleanup and centralise DEVELHELP setting #8029

Merged

smlng mentioned this pull request Nov 18, 2017

make: adapt develhelp for all examples #8081

Merged

smlng removed the State: waiting for other PR State: The PR requires another PR to be merged first label Nov 28, 2017

smlng force-pushed the enh/tests/develhelp branch from db743a2 to 36fe812 Compare November 28, 2017 09:50

smlng added the Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties label Nov 28, 2017

smlng force-pushed the enh/tests/develhelp branch from 36fe812 to 019b586 Compare November 28, 2017 21:21

kaspar030 requested changes Nov 29, 2017

View reviewed changes

smlng force-pushed the enh/tests/develhelp branch from 729801e to 81728be Compare November 29, 2017 12:12

smlng mentioned this pull request Nov 29, 2017

cpu, efm32_common: fix sign-compare error in flashpage #8175

Merged

smlng force-pushed the enh/tests/develhelp branch from 5692386 to 1888134 Compare November 29, 2017 15:15

smlng mentioned this pull request Nov 29, 2017

unittests: fix gnrc_ipv6_nib test #8177

Merged

smlng force-pushed the enh/tests/develhelp branch from 1888134 to 88a0e5e Compare November 29, 2017 21:00

smlng removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 6, 2017

smlng force-pushed the enh/tests/develhelp branch from 88a0e5e to 09359d9 Compare December 6, 2017 21:52

smlng force-pushed the enh/tests/develhelp branch from 09359d9 to 66932f0 Compare December 7, 2017 22:39

smlng mentioned this pull request Dec 10, 2017

cpu/sam0_common: fix assert in periph/flashpage #8233

Merged

smlng added the State: waiting for other PR State: The PR requires another PR to be merged first label Dec 10, 2017

miri64 assigned kaspar030 Dec 11, 2017

kaspar030 reviewed Dec 11, 2017

View reviewed changes

smlng force-pushed the enh/tests/develhelp branch from 66932f0 to 7fdc09e Compare December 13, 2017 20:52

smlng mentioned this pull request Dec 13, 2017

unittests: fix failed assertion caused by priority_pktqueue #8259

Merged

smlng force-pushed the enh/tests/develhelp branch 3 times, most recently from 5f786f1 to 73abd7b Compare December 13, 2017 21:26

smlng added 3 commits December 14, 2017 17:54

tests: remove DEVELHELP from per test Makefiles

6f67e75

tests: enable DEVELHELP for all tests by default

ea9aecd

tests/minimal: disable develhelp

bbbf2bf

to ensure minimal binary size for comparison

smlng force-pushed the enh/tests/develhelp branch from 73abd7b to 1f4dab8 Compare December 14, 2017 16:55

tests: adapt BOARD_INSUFFICIENT_MEMORY

0ec7630

smlng force-pushed the enh/tests/develhelp branch from 1f4dab8 to 0ec7630 Compare December 14, 2017 17:03

kaspar030 approved these changes Dec 15, 2017

View reviewed changes

kaspar030 merged commit 4579deb into RIOT-OS:master Dec 15, 2017

smlng deleted the enh/tests/develhelp branch December 15, 2017 10:39

This was referenced Dec 22, 2017

drivers/rn2xx3: basic initial implementation (without netdev) #7505

Merged

Generic memory block allocator #7651

Merged

aabadie added this to the Release 2018.01 milestone Jan 18, 2018

smlng mentioned this pull request Jan 23, 2018

Release 2018.01 - RC1 RIOT-OS/Release-Specs#55

Closed

43 tasks



		CFLAGS += -DDEVELHELP
		CFLAGS += -DLOG_LEVEL=LOG_ALL

Conversation

smlng commented Nov 17, 2017

Uh oh!

miri64 commented Nov 17, 2017

Uh oh!

miri64 commented Nov 27, 2017

Uh oh!

smlng commented Nov 28, 2017

Uh oh!

smlng commented Nov 28, 2017

Uh oh!

kaspar030 left a comment

Choose a reason for hiding this comment

Uh oh!

kaspar030 Nov 29, 2017

Choose a reason for hiding this comment

Uh oh!

smlng Nov 29, 2017

Choose a reason for hiding this comment

Uh oh!

kaspar030 Nov 29, 2017

Choose a reason for hiding this comment

Uh oh!

smlng Nov 29, 2017

Choose a reason for hiding this comment

Uh oh!

kaspar030 commented Nov 29, 2017

Uh oh!

smlng commented Nov 29, 2017

Uh oh!

kaspar030 commented Nov 29, 2017

Uh oh!

smlng commented Nov 29, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smlng commented Nov 29, 2017

Uh oh!

kaspar030 commented Nov 30, 2017

Uh oh!

smlng commented Nov 30, 2017

Uh oh!

smlng commented Dec 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kaspar030 Dec 11, 2017

Choose a reason for hiding this comment

Uh oh!

smlng commented Dec 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smlng commented Dec 14, 2017

Uh oh!

smlng commented Dec 15, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

smlng commented Nov 29, 2017 •

edited

Loading

smlng commented Dec 10, 2017 •

edited

Loading

smlng commented Dec 13, 2017 •

edited

Loading