dist: adapt develhelp in Makefile #8079
Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom Nov 30, 2017
Merged
Conversation
smlng
added
Type: cleanup
smlng
changed the title
kaspar030
requested changes
Nov 17, 2017
| # with the target all-valgrind instead of all: | ||
| # make -B clean all-valgrind | ||
|
|
||
| # Uncomment this to enable code in RIOT that does safety checking |
Contributor
There was a problem hiding this comment.
IMO this was useful and should be adapted to use the new DEVELHELP variable.
Member
Author
There was a problem hiding this comment.
I agree, but with the new switch, DEVELHELP can enabled via env variable from everywhere, so no need to have this comment out option here. But I could leave a comment here, how to enable DEVELHELP, instead?
Contributor
There was a problem hiding this comment.
I'd keep it as before, but no using #DEVELHELP = 1
smlng
force-pushed
the
enh/dist/develhelp
branch
from
e20450a to
74070b5
Compare
smlng
changed the title
smlng
removed
the
State: waiting for other PR
smlng
force-pushed
the
enh/dist/develhelp
branch
from
74070b5 to
c93d1ca
Compare
Member
Author
|
rebased |
smlng
added
the
Community: Hack'n'ACK candidate
Member
Author
|
ping @kaspar030 |
kaspar030
approved these changes
Nov 30, 2017
Contributor
|
ACK&go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
factored out from #8029, remove obsolete comment on develhelp.