shell: do not advertise reactively in 6ctx command#8077
Merged
cgundogan merged 1 commit intoRIOT-OS:gnrc_netif2_integration/masterfrom Nov 19, 2017
Merged
Conversation
After thinking about it a bit, I decided to remove the reactive advertisement of context information all together in the shell command. RFC 6775 does not explicitly forbids, but it discourages multicast RAs, which would be the alternative.
28 tasks
miri64
added
the
CI: ready for build
cgundogan
approved these changes
Nov 19, 2017
Member
cgundogan
left a comment
cgundogan
left a comment
There was a problem hiding this comment.
Okay, no strong opinion about that. Change is sane, though. ACK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After thinking about it a bit, I decided to remove the reactive
advertisement of context information all together in the shell command.
RFC 6775 does not explicitly forbids, but it discourages multicast RAs,
which would be the alternative.