Skip to content

boards: removed support for pca1000[0|5] (gnrc_netif2 backport)#8074

Merged
miri64 merged 5 commits intoRIOT-OS:gnrc_netif2_integration/masterfrom
miri64:git/fix/7979-backport
Nov 17, 2017
Merged

boards: removed support for pca1000[0|5] (gnrc_netif2 backport)#8074
miri64 merged 5 commits intoRIOT-OS:gnrc_netif2_integration/masterfrom
miri64:git/fix/7979-backport

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Nov 17, 2017

To solve the merge conflict in #7925, this backports #7979 to #7925. The merge in d683afd has to stay in I'm afraid, so git can keep track of the move of test/gnrc_netif2 to test/gnrc_netif. I'm not happy about this approach, but save from rebasing (which again: would require re-reviewing all changes that were contributed to #7925) this seems to be the sanest approach.

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) GNRC Area: network Area: Networking labels Nov 17, 2017
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 17, 2017
Copy link
Copy Markdown
Contributor

@haukepetersen haukepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AC

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 17, 2017

static tests fail because Murdock is doing a rebase instead of a merge so my git history hack does not apply for it. Since we merge this PR anyways instead of rebasing it, I would say: merge anyway. Can I get an 'Aye'?

@haukepetersen
Copy link
Copy Markdown
Contributor

'Ei'

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 17, 2017

🥚

@miri64 miri64 merged commit 10a01dc into RIOT-OS:gnrc_netif2_integration/master Nov 17, 2017
@miri64 miri64 deleted the git/fix/7979-backport branch November 17, 2017 13:39
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 17, 2017

Wasn't the sanest idea after all -.-... will revert this

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 17, 2017

For later reference: this PR was removed without any trace from the git history in #7925 after it was merged.

@aabadie aabadie added this to the Release 2018.01 milestone Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants