Skip to content

gnrc_ipv6_nib: add timeouts to routes#8073

Merged
cgundogan merged 4 commits intoRIOT-OS:gnrc_netif2_integration/masterfrom
miri64:gnrc_ipv6_nib/feat/route-timeout
Nov 19, 2017
Merged

gnrc_ipv6_nib: add timeouts to routes#8073
cgundogan merged 4 commits intoRIOT-OS:gnrc_netif2_integration/masterfrom
miri64:gnrc_ipv6_nib/feat/route-timeout

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Nov 17, 2017

RPL requires route timeouts and this PR adds them. In communication with @cgundogan I only decided for a second resolution for that.

@miri64 miri64 added Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. GNRC Area: network Area: Networking labels Nov 17, 2017
@miri64 miri64 requested a review from cgundogan November 17, 2017 12:46
@cgundogan
Copy link
Copy Markdown
Member

From first sight it looks good. Will do a more thorough review later today with the RPL port in mind.

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 18, 2017
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Nov 18, 2017

ping @cgundogan do we get this in before your vacation?

Copy link
Copy Markdown
Member

@cgundogan cgundogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent! ACK

@cgundogan cgundogan added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 19, 2017
@cgundogan cgundogan merged commit 4a0d57c into RIOT-OS:gnrc_netif2_integration/master Nov 19, 2017
@miri64 miri64 deleted the gnrc_ipv6_nib/feat/route-timeout branch November 20, 2017 13:31
@aabadie aabadie added this to the Release 2018.01 milestone Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants